From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3dWB-0001Xo-BS for qemu-devel@nongnu.org; Thu, 27 Apr 2017 03:07:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d3dW8-0007mu-5D for qemu-devel@nongnu.org; Thu, 27 Apr 2017 03:07:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60156) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d3dW7-0007kV-T9 for qemu-devel@nongnu.org; Thu, 27 Apr 2017 03:07:08 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E523E7E9D5 for ; Thu, 27 Apr 2017 07:07:06 +0000 (UTC) From: Markus Armbruster References: <1493192675-16104-1-git-send-email-peterx@redhat.com> <1493192675-16104-3-git-send-email-peterx@redhat.com> <8760hrxtcn.fsf@dusky.pond.sub.org> <20170427020931.GD26792@pxdev.xzpeter.org> Date: Thu, 27 Apr 2017 09:07:01 +0200 In-Reply-To: <20170427020931.GD26792@pxdev.xzpeter.org> (Peter Xu's message of "Thu, 27 Apr 2017 10:09:31 +0800") Message-ID: <87h91ajpm2.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 2/2] ramblock: add new hmp command "info ramblock" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: Paolo Bonzini , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" Peter Xu writes: > On Wed, Apr 26, 2017 at 02:10:16PM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > To dump information about ramblocks. It looks like: >> > >> > (qemu) info ramblock >> > Block Name PSize Offset Used Total >> > /objects/mem 2M 0x0000000000000000 0x0000000080000000 0x0000000080000000 >> > vga.vram 4K 0x0000000080060000 0x0000000001000000 0x0000000001000000 >> > /rom@etc/acpi/tables 4K 0x00000000810b0000 0x0000000000020000 0x0000000000200000 >> > pc.bios 4K 0x0000000080000000 0x0000000000040000 0x0000000000040000 >> > 0000:00:03.0/e1000.rom 4K 0x0000000081070000 0x0000000000040000 0x0000000000040000 >> > pc.rom 4K 0x0000000080040000 0x0000000000020000 0x0000000000020000 >> > 0000:00:02.0/vga.rom 4K 0x0000000081060000 0x0000000000010000 0x0000000000010000 >> > /rom@etc/table-loader 4K 0x00000000812b0000 0x0000000000001000 0x0000000000001000 >> > /rom@etc/acpi/rsdp 4K 0x00000000812b1000 0x0000000000001000 0x0000000000001000 >> > >> > Signed-off-by: Peter Xu >> >> You implemented this just for HMP. >> >> In general, functionality available in HMP should also available in QMP. >> Exceptions include functionality that makes no sense in QMP, or is of >> use only for human users. If you think your command is an exception, >> please explain why in the commit message. >> >> If it isn't, you need to implement it for QMP, then rewrite the HMP >> version to reuse either the QMP command or a common core. > > I see. I think it should belongs to the first condition, which should > only be used by human users, especially developers. Maybe I can repost > with some more comment in the commit message to emphasize that. Example for "makes no sense in QMP": setting the current CPU[1], because a QMP monitor doesn't have a current CPU. Examples for "is of use only for human users": HMP command "help", the integrated pocket calculator[2]. > But, before that, I would also want to know whether anyone would think > this an useful thing even to QMP... If so, I would be glad to provide > QMP interface as well. Can't say without understanding the use cases. Perhaps you can start with explaining the itch your HMP command scratches. [1] For reasons lost in time, we added QMP command "cpu" anyway, it just does nothing. [2] I doubt that one is of much use to humans, either.