From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Date: Mon, 27 Feb 2017 10:18:20 +0000 Subject: Re: [patch v2] drm/msm/dsi: free first element on error Message-Id: <87h93ggcnn.fsf@intel.com> List-Id: References: <87a89mnznw.fsf@intel.com> <20170216120028.GA29698@mwanda> <871suynwwz.fsf@intel.com> <20170226205210.nalhhhxmosn4ndci@phenom.ffwll.local> In-Reply-To: <20170226205210.nalhhhxmosn4ndci@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Daniel Vetter Cc: linux-arm-msm , kernel-janitors@vger.kernel.org, Wei Yongjun , "dri-devel@lists.freedesktop.org" , freedreno@lists.freedesktop.org, Dan Carpenter On Sun, 26 Feb 2017, Daniel Vetter wrote: > On Thu, Feb 16, 2017 at 02:27:08PM +0200, Jani Nikula wrote: >> On Thu, 16 Feb 2017, Rob Clark wrote: >> > On Thu, Feb 16, 2017 at 7:00 AM, Dan Carpenter wrote: >> >> We're off by one here. We free something that wasn't allocated and we >> >> don't free msm_host->bus_clks[]. >> >> >> >> Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list") >> >> Signed-off-by: Dan Carpenter >> > >> > Thanks >> > >> > Reviewed-by: Rob Clark >> >> And for good measure, >> >> Reviewed-by: Jani Nikula > > So 2 r-b from maintainers, no one said he'll apply. This isn't really > great coordination :-) Note that drm-misc-next is always open, so you > could always smash it in there, irrespective of merge window state. hint, > hint ... Admittedly I shied away from touching drm/msm. BR, Jani. > -Daniel > >> >> >> > >> >> >> >> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c >> >> index 1fc07ce24686..4fa32296162e 100644 >> >> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c >> >> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c >> >> @@ -437,7 +437,7 @@ static int dsi_bus_clk_enable(struct msm_dsi_host *msm_host) >> >> >> >> return 0; >> >> err: >> >> - for (; i > 0; i--) >> >> + while (i--) >> >> clk_disable_unprepare(msm_host->bus_clks[i]); >> >> >> >> return ret; >> >> -- >> Jani Nikula, Intel Open Source Technology Center >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [patch v2] drm/msm/dsi: free first element on error Date: Mon, 27 Feb 2017 12:18:20 +0200 Message-ID: <87h93ggcnn.fsf@intel.com> References: <87a89mnznw.fsf@intel.com> <20170216120028.GA29698@mwanda> <871suynwwz.fsf@intel.com> <20170226205210.nalhhhxmosn4ndci@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170226205210.nalhhhxmosn4ndci@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: linux-arm-msm , kernel-janitors@vger.kernel.org, Wei Yongjun , "dri-devel@lists.freedesktop.org" , freedreno@lists.freedesktop.org, Dan Carpenter List-Id: linux-arm-msm@vger.kernel.org T24gU3VuLCAyNiBGZWIgMjAxNywgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90 ZToKPiBPbiBUaHUsIEZlYiAxNiwgMjAxNyBhdCAwMjoyNzowOFBNICswMjAwLCBKYW5pIE5pa3Vs YSB3cm90ZToKPj4gT24gVGh1LCAxNiBGZWIgMjAxNywgUm9iIENsYXJrIDxyb2JkY2xhcmtAZ21h aWwuY29tPiB3cm90ZToKPj4gPiBPbiBUaHUsIEZlYiAxNiwgMjAxNyBhdCA3OjAwIEFNLCBEYW4g Q2FycGVudGVyIDxkYW4uY2FycGVudGVyQG9yYWNsZS5jb20+IHdyb3RlOgo+PiA+PiBXZSdyZSBv ZmYgYnkgb25lIGhlcmUuICBXZSBmcmVlIHNvbWV0aGluZyB0aGF0IHdhc24ndCBhbGxvY2F0ZWQg YW5kIHdlCj4+ID4+IGRvbid0IGZyZWUgbXNtX2hvc3QtPmJ1c19jbGtzW10uCj4+ID4+Cj4+ID4+ IEZpeGVzOiA2ZTBlYjUyZWJhOWUgKCJkcm0vbXNtL2RzaTogUGFyc2UgYnVzIGNsb2NrcyBmcm9t IGEgbGlzdCIpCj4+ID4+IFNpZ25lZC1vZmYtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50 ZXJAb3JhY2xlLmNvbT4KPj4gPgo+PiA+IFRoYW5rcwo+PiA+Cj4+ID4gUmV2aWV3ZWQtYnk6IFJv YiBDbGFyayA8cm9iZGNsYXJrQGdtYWlsLmNvbT4KPj4gCj4+IEFuZCBmb3IgZ29vZCBtZWFzdXJl LAo+PiAKPj4gUmV2aWV3ZWQtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+ Cj4KPiBTbyAyIHItYiBmcm9tIG1haW50YWluZXJzLCBubyBvbmUgc2FpZCBoZSdsbCBhcHBseS4g VGhpcyBpc24ndCByZWFsbHkKPiBncmVhdCBjb29yZGluYXRpb24gOi0pIE5vdGUgdGhhdCBkcm0t bWlzYy1uZXh0IGlzIGFsd2F5cyBvcGVuLCBzbyB5b3UKPiBjb3VsZCBhbHdheXMgc21hc2ggaXQg aW4gdGhlcmUsIGlycmVzcGVjdGl2ZSBvZiBtZXJnZSB3aW5kb3cgc3RhdGUuIGhpbnQsCj4gaGlu dCAuLi4KCkFkbWl0dGVkbHkgSSBzaGllZCBhd2F5IGZyb20gdG91Y2hpbmcgZHJtL21zbS4KCkJS LApKYW5pLgoKPiAtRGFuaWVsCj4KPj4gCj4+IAo+PiA+Cj4+ID4+Cj4+ID4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vbXNtL2RzaS9kc2lfaG9zdC5jIGIvZHJpdmVycy9ncHUvZHJtL21z bS9kc2kvZHNpX2hvc3QuYwo+PiA+PiBpbmRleCAxZmMwN2NlMjQ2ODYuLjRmYTMyMjk2MTYyZSAx MDA2NDQKPj4gPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9kc2kvZHNpX2hvc3QuYwo+PiA+ PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2RzaS9kc2lfaG9zdC5jCj4+ID4+IEBAIC00Mzcs NyArNDM3LDcgQEAgc3RhdGljIGludCBkc2lfYnVzX2Nsa19lbmFibGUoc3RydWN0IG1zbV9kc2lf aG9zdCAqbXNtX2hvc3QpCj4+ID4+Cj4+ID4+ICAgICAgICAgcmV0dXJuIDA7Cj4+ID4+ICBlcnI6 Cj4+ID4+IC0gICAgICAgZm9yICg7IGkgPiAwOyBpLS0pCj4+ID4+ICsgICAgICAgd2hpbGUgKGkt LSkKPj4gPj4gICAgICAgICAgICAgICAgIGNsa19kaXNhYmxlX3VucHJlcGFyZShtc21faG9zdC0+ YnVzX2Nsa3NbaV0pOwo+PiA+Pgo+PiA+PiAgICAgICAgIHJldHVybiByZXQ7Cj4+IAo+PiAtLSAK Pj4gSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCj4+IF9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+IGRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKPj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0g CkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK