From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39389)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <whitebox@nefkom.net>) id 1c6llh-0005zF-30
	for qemu-devel@nongnu.org; Tue, 15 Nov 2016 16:59:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <whitebox@nefkom.net>) id 1c6llc-0002zm-9t
	for qemu-devel@nongnu.org; Tue, 15 Nov 2016 16:59:53 -0500
Received: from mail-out.m-online.net ([212.18.0.10]:42897)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <whitebox@nefkom.net>) id 1c6llc-0002xI-3X
	for qemu-devel@nongnu.org; Tue, 15 Nov 2016 16:59:48 -0500
From: Andreas Schwab <schwab@linux-m68k.org>
References: <1479242669-25852-1-git-send-email-rth@twiddle.net>
	<2da99c2f-f8d8-1305-e9ce-33a66309c57e@vivier.eu>
	<e50b6500-32ec-cdee-397a-e4ea383f46cf@vivier.eu>
	<d9563bc3-bbb4-0abb-80ac-13a72b28f218@twiddle.net>
Date: Tue, 15 Nov 2016 22:59:42 +0100
In-Reply-To: <d9563bc3-bbb4-0abb-80ac-13a72b28f218@twiddle.net> (Richard
	Henderson's message of "Tue, 15 Nov 2016 22:18:18 +0100")
Message-ID: <87h978cskx.fsf@linux-m68k.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] target-m68k: Implement bfffo
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org

On Nov 15 2016, Richard Henderson <rth@twiddle.net> wrote:

> On 11/15/2016 10:12 PM, Laurent Vivier wrote:
>> Le 15/11/2016 =C3=A0 22:07, Laurent Vivier a =C3=A9crit :
>>> Le 15/11/2016 =C3=A0 21:44, Richard Henderson a =C3=A9crit :
>>>> @@ -5415,6 +5450,8 @@ void register_m68k_insns (CPUM68KState *env)
>>>>      INSN(bfop_reg, eac0, fff8, BITFIELD);   /* bfchg */
>>>>      INSN(bfop_mem, ecc0, ffc0, BITFIELD);   /* bfclr */
>>>>      INSN(bfop_reg, ecc0, fff8, BITFIELD);   /* bfclr */
>>>> +    INSN(bfop_mem, edc0, ffc0, BITFIELD);   /* bfffo */
>>>> +    INSN(bfop_reg, edc0, fff8, BITFIELD);   /* bfffo */
>>>
>>> In my doc, bfffo is 0xE9C0.
>>
>> I think my doc [1] is wrong, because it is the same as bextu and the
>> as/objdump gives me 0xEDC0.
>
> My doc gives the same wrong opcode on the bfffo description page.  It
> confused me for some time until I scrolled to the opcode map at the end=
 of
> the document, where it is correctly identified as EDC0.

The printed manual has the correct opcode, it is only wrong in the PDF.

Andreas.

--=20
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint =3D 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED=
5
"And now for something completely different."