From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: RE: [PATCH]"drm: change DRM_MIPI_DSI module type from "bool" to "tristate". Date: Wed, 12 Oct 2016 13:52:46 +0300 Message-ID: <87h98hyh35.fsf@intel.com> References: <87h98ktxow.fsf@intel.com> <87lgxvqlg3.fsf@intel.com> <20161012065136.GH20761@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5045E6E80F for ; Wed, 12 Oct 2016 10:52:50 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Sun, Jing A" , Daniel Vetter Cc: Emil Velikov , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "Vetter, Daniel" , Thierry Reding List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAxMiBPY3QgMjAxNiwgIlN1biwgSmluZyBBIiA8amluZy5hLnN1bkBpbnRlbC5jb20+ IHdyb3RlOgo+IEkgdGhpbmsgImluc3RhbGxpbmcgYSBrZXJuZWwgd2l0aCBteSBjaGFuZ2VzIGZv ciBib3RoIGRybSBhbmQgaTkxNSIKPiB0YWtlcyBtb3JlIHRpbWUgYW5kIGVmZm9ydCB0byBjb21w bGV0ZSB0aGFuICJvbmx5IHVwZGF0aW5nIERSTS9pOTE1Cj4gbW9kdWxlcyB3aXRob3V0IHJlYnVp bGRpbmcgdGhlIHdob2xlIGtlcm5lbCIuIEluIHNvbWUgY2FzZXMsIHRoYXQncwo+IGJlbmVmaWNp YWwuCgpJdCdzIHBvc3NpYmxlIHRvIGNoYW5nZSBhbmQgcmVidWlsZCBhbmQgdXBkYXRlIGp1c3Qg dGhlIGRybSBhbmQgaTkxNSwKYnV0IHlvdSBuZWVkIHRvIGJlIGNhcmVmdWwgdG8gYnVpbGQgYWdh aW5zdCB0aGUgc2FtZSB0cmVlIGFzIHRoZSBvbmVzCnlvdSBhcmUgcmVwbGFjaW5nLiBUaGlzIGlz IGxpa2UgdXNpbmcgb3V0LW9mLXRyZWUgbW9kdWxlcyAod2hpY2ggaXMKc29tZXRoaW5nIEkgY2Fu J3QgcmVjb21tZW5kIG5vIG1hdHRlciB3aGF0LCBidXQgdGhhdCdzIGFub3RoZXIKZGlzY3Vzc2lv bikuCgpIb3dldmVyLCB0aGlzIGlzIGNvbXBsZXRlbHkgZGlmZmVyZW50IGZyb20gcGxhbm5pbmcg dG8gdXBkYXRlIGRybSBhbmQKaTkxNSBtb2R1bGVzIG9uIGEgcnVubmluZyBwcm9kdWN0aW9uIHN5 c3RlbSBieSB1bmxvYWRpbmcgdGhlIG9sZCBvbmVzCmFuZCBwcm9iaW5nIHRoZSBuZXcgb25lcy4g RG9uJ3QgZG8gdGhhdC4gSXQgd2lsbCBiZSBhIGRpc2FzdGVyLgoKPiBBbHNvIHJlbG9hZGFibGls aXR5IGlzIGFsd2F5cyBhIGdvb2QgdGhpbmcgdG8gaGF2ZSBhbmQgSSB0cnVseSBob3BlCj4gSGFq ZGEvSXdhaSdzIHBhdGNoZXMgd291bGQgYmUgYWNjZXB0ZWQgYW5kIG1lcmdlZC4gIE5vIGRvd25z aWRlIG9mIGl0Cj4gYWZ0ZXIgYWxsLgoKSSB0aGluayBpdCdzIGdvb2QgdG8gYmUgYWJsZSB0byB1 bmxvYWQgYW5kIHJlbG9hZCBtb2R1bGVzIGZvciBkZWJ1Z2dpbmcKYW5kIGRldmVsb3BtZW50LCBi dXQgbm90IGZvciBub3JtYWwgdXNlLgoKQlIsCkphbmkuCgoKLS0gCkphbmkgTmlrdWxhLCBJbnRl bCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932775AbcJLKxo (ORCPT ); Wed, 12 Oct 2016 06:53:44 -0400 Received: from mga11.intel.com ([192.55.52.93]:20995 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932615AbcJLKxi (ORCPT ); Wed, 12 Oct 2016 06:53:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,333,1473145200"; d="scan'208";a="771715658" From: Jani Nikula To: "Sun\, Jing A" , Daniel Vetter Cc: Andrzej Hajda , Takashi Iwai , Emil Velikov , "linux-kernel\@vger.kernel.org" , "dri-devel\@lists.freedesktop.org" , "Vetter\, Daniel" , Thierry Reding Subject: RE: [PATCH]"drm: change DRM_MIPI_DSI module type from "bool" to "tristate". In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <87h98ktxow.fsf@intel.com> <87lgxvqlg3.fsf@intel.com> <20161012065136.GH20761@phenom.ffwll.local> Date: Wed, 12 Oct 2016 13:52:46 +0300 Message-ID: <87h98hyh35.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 12 Oct 2016, "Sun, Jing A" wrote: > I think "installing a kernel with my changes for both drm and i915" > takes more time and effort to complete than "only updating DRM/i915 > modules without rebuilding the whole kernel". In some cases, that's > beneficial. It's possible to change and rebuild and update just the drm and i915, but you need to be careful to build against the same tree as the ones you are replacing. This is like using out-of-tree modules (which is something I can't recommend no matter what, but that's another discussion). However, this is completely different from planning to update drm and i915 modules on a running production system by unloading the old ones and probing the new ones. Don't do that. It will be a disaster. > Also reloadablility is always a good thing to have and I truly hope > Hajda/Iwai's patches would be accepted and merged. No downside of it > after all. I think it's good to be able to unload and reload modules for debugging and development, but not for normal use. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center