From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>, kernel-build-reports@lists.linaro.org
Cc: Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Magnus Damm <damm+renesas@opensource.se>,
Simon Horman <horms+renesas@verge.net.au>,
linaro-kernel@lists.linaro.org, linux-next@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH, RESEND] staging: emxx_udc: allow modular build
Date: Tue, 05 Jul 2016 13:06:02 +0300 [thread overview]
Message-ID: <87h9c4l7qt.fsf@linux.intel.com> (raw)
In-Reply-To: <4551753.qTqdp3sOje@wuerfel>
[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]
Hi,
Arnd Bergmann <arnd@arndb.de> writes:
> A change to the usb gadget core allowed certain API functions to be
> part of a loadable module, which breaks having emxx_udc built-in:
>
> drivers/staging/built-in.o: In function `nbu2ss_drv_probe':
> (.text+0x2428): undefined reference to `usb_ep_set_maxpacket_limit'
>
> The original patch already fixed tons of other cases that have the
> added dependency but apparently missed this one that now appears
> in an ARM allmodconfig build.
>
> This patch makes the symbol "tristate", which lets the Kconfig
> dependency tracking handle it correctly. To make the module
> actually usable, I also revert 0af61e66ee16 ("drivers/staging:
> make emxx_udc.c explicitly non-modular"), which Paul Gortmaker
> added after noticing that the Kconfig symbol was 'bool'.
> Compared to the original version however, I leave out the
> '__exit' annotation on the remove callback, as Paul pointed
> out that this was incorrect.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 5a8d651a2bde ("usb: gadget: move gadget API functions to udc-core")
Sorry guys, I didn't know we had UDC drivers sitting in staging.
Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-07-05 10:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 9:15 next-20160705 build: 2 failures 6 warnings (next-20160705) Build bot for Mark Brown
2016-07-05 9:52 ` Mark Brown
2016-07-05 10:00 ` [PATCH, RESEND] staging: emxx_udc: allow modular build Arnd Bergmann
2016-07-05 10:06 ` Felipe Balbi [this message]
2016-07-06 2:31 ` next-20160705 build: 2 failures 6 warnings (next-20160705) Peter Chen
2016-07-06 3:00 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9c4l7qt.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=damm+renesas@opensource.se \
--cc=gregkh@linuxfoundation.org \
--cc=horms+renesas@verge.net.au \
--cc=kernel-build-reports@lists.linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.