From: Markus Armbruster <armbru@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Marcel Apfelbaum <marcel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 01/10] qdev: Don't stop applying globals on first error
Date: Mon, 20 Jun 2016 09:43:15 +0200 [thread overview]
Message-ID: <87h9cocnl8.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <1466022773-8965-2-git-send-email-ehabkost@redhat.com> (Eduardo Habkost's message of "Wed, 15 Jun 2016 17:32:44 -0300")
Eduardo Habkost <ehabkost@redhat.com> writes:
> qdev_prop_set_globals_for_type() stops applying global properties
> on the first error. It is a leftover from when QEMU exited on any
> error when applying global property. Now we print a warning about
> the first error, bug ignore all other global properties after it.
Might want to add "Messed up in commit 25f8dd9."
> For example, the following command-line will not set CPUID level
> to 3, but will warn only about "x86_64-cpu.vendor" being ignored.
>
> $ ./x86_64-softmmu/qemu-system-x86_64 \
> -global x86_64-cpu.vendor=x \
> -global x86_64-cpu.level=3
> qemu-system-x86_64: Warning: global x86_64-cpu.vendor=x ignored: Property '.vendor' doesn't take value 'x'
>
> Fix this by not returning from qdev_prop_set_globals_for_type()
> on the first error.
>
> Cc: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2016-06-20 7:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 20:32 [Qemu-devel] [PATCH 00/10] globals: Clean up validation and error checking Eduardo Habkost
2016-06-15 20:32 ` [Qemu-devel] [PATCH 01/10] qdev: Don't stop applying globals on first error Eduardo Habkost
2016-06-19 16:40 ` Marcel Apfelbaum
2016-06-20 7:43 ` Markus Armbruster [this message]
2016-06-15 20:32 ` [Qemu-devel] [PATCH 02/10] qdev: Eliminate qemu_add_globals() function Eduardo Habkost
2016-06-20 12:03 ` Igor Mammedov
2016-06-15 20:32 ` [Qemu-devel] [PATCH 03/10] vl: Reject invalid class names on -global Eduardo Habkost
2016-06-20 7:56 ` Markus Armbruster
2016-06-20 12:44 ` Igor Mammedov
2016-06-15 20:32 ` [Qemu-devel] [PATCH 04/10] qdev: Use error_prepend() for errors applying globals Eduardo Habkost
2016-06-20 8:02 ` Markus Armbruster
2016-06-20 13:43 ` Eduardo Habkost
2016-06-15 20:32 ` [Qemu-devel] [PATCH 05/10] qdev: GlobalProperty.errp field Eduardo Habkost
2016-06-20 8:14 ` Markus Armbruster
2016-06-20 13:45 ` Eduardo Habkost
2016-06-15 20:32 ` [Qemu-devel] [PATCH 06/10] machine: Add machine_register_compat_props() function Eduardo Habkost
2016-06-19 16:25 ` Marcel Apfelbaum
2016-06-15 20:32 ` [Qemu-devel] [PATCH 07/10] vl: Set errp to &error_abort on machine compat_props Eduardo Habkost
2016-06-19 16:27 ` Marcel Apfelbaum
2016-06-15 20:32 ` [Qemu-devel] [PATCH 08/10] qdev: Eliminate "global not used" warning Eduardo Habkost
2016-06-15 20:32 ` [Qemu-devel] [PATCH 09/10] qdev: Eliminate GlobalProperty 'used' and 'user_provided' fields Eduardo Habkost
2016-06-15 20:32 ` [Qemu-devel] [PATCH 10/10] machine: Skip global registration for non-existing classes Eduardo Habkost
2016-06-19 16:39 ` Marcel Apfelbaum
2016-06-19 16:50 ` Marcel Apfelbaum
2016-06-20 13:38 ` Eduardo Habkost
2016-06-20 13:11 ` [Qemu-devel] [PATCH 00/10] globals: Clean up validation and error checking Igor Mammedov
2016-06-20 13:48 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9cocnl8.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=marcel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.