From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHDlB-0004qM-7p for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:50:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHDl8-0008UR-2A for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:50:01 -0500 Received: from e28smtp02.in.ibm.com ([125.16.236.2]:52540) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHDl7-0008Qo-Cc for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:49:57 -0500 Received: from localhost by e28smtp02.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 7 Jan 2016 22:19:54 +0530 Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 39B8CE0054 for ; Thu, 7 Jan 2016 22:21:05 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay01.in.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u07Gnn5o66781380 for ; Thu, 7 Jan 2016 22:19:50 +0530 Received: from d28av03.in.ibm.com (localhost [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u07GnnQt008594 for ; Thu, 7 Jan 2016 22:19:49 +0530 From: "Aneesh Kumar K.V" In-Reply-To: <1452020761-24457-13-git-send-email-wei.liu2@citrix.com> References: <1452020761-24457-1-git-send-email-wei.liu2@citrix.com> <1452020761-24457-13-git-send-email-wei.liu2@citrix.com> Date: Thu, 07 Jan 2016 22:19:47 +0530 Message-ID: <87h9ipqqqc.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 12/22] 9pfs: use V9fsBlob to transmit xattr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Liu , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Greg Kurz Wei Liu writes: > And make v9fs_pack static function. Now we only need to export > v9fs_{,un}marshal to device. Any advantage of doing this ? compared to v9fs_pack ?. Trying to understand if i am missing something here > > Signed-off-by: Wei Liu > --- > fsdev/virtio-9p-marshal.c | 4 ++-- > fsdev/virtio-9p-marshal.h | 3 --- > hw/9pfs/virtio-9p.c | 21 +++++++++++++-------- > 3 files changed, 15 insertions(+), 13 deletions(-) > > diff --git a/fsdev/virtio-9p-marshal.c b/fsdev/virtio-9p-marshal.c > index c3ac316..d120bd2 100644 > --- a/fsdev/virtio-9p-marshal.c > +++ b/fsdev/virtio-9p-marshal.c > @@ -70,8 +70,8 @@ static ssize_t v9fs_unpack(void *dst, struct iovec *out_sg, int out_num, > return v9fs_packunpack(dst, out_sg, out_num, offset, size, 0); > } > > -ssize_t v9fs_pack(struct iovec *in_sg, int in_num, size_t offset, > - const void *src, size_t size) > +static ssize_t v9fs_pack(struct iovec *in_sg, int in_num, size_t offset, > + const void *src, size_t size) > { > return v9fs_packunpack((void *)src, in_sg, in_num, offset, size, 1); > } > diff --git a/fsdev/virtio-9p-marshal.h b/fsdev/virtio-9p-marshal.h > index 0709bcd..766a48e 100644 > --- a/fsdev/virtio-9p-marshal.h > +++ b/fsdev/virtio-9p-marshal.h > @@ -3,9 +3,6 @@ > > #include "9p-marshal.h" > > - > -ssize_t v9fs_pack(struct iovec *in_sg, int in_num, size_t offset, > - const void *src, size_t size); > ssize_t v9fs_unmarshal(struct iovec *out_sg, int out_num, size_t offset, > int bswap, const char *fmt, ...); > ssize_t v9fs_marshal(struct iovec *in_sg, int in_num, size_t offset, > diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c > index 084fa6a..5da25ec 100644 > --- a/hw/9pfs/virtio-9p.c > +++ b/hw/9pfs/virtio-9p.c > @@ -1561,6 +1561,7 @@ static int v9fs_xattr_read(V9fsState *s, V9fsPDU *pdu, V9fsFidState *fidp, > size_t offset = 7; > int read_count; > int64_t xattr_len; > + V9fsBlob blob; > > xattr_len = fidp->fs.xattr.len; > read_count = xattr_len - off; > @@ -1572,14 +1573,18 @@ static int v9fs_xattr_read(V9fsState *s, V9fsPDU *pdu, V9fsFidState *fidp, > */ > read_count = 0; > } > - err = pdu_marshal(pdu, offset, "d", read_count); > - if (err < 0) { > - return err; > - } > - offset += err; > - err = v9fs_pack(pdu->elem.in_sg, pdu->elem.in_num, offset, > - ((char *)fidp->fs.xattr.value) + off, > - read_count); > + > + v9fs_blob_init(&blob); > + > + blob.data = g_malloc(read_count); > + memcpy(blob.data, ((char *)fidp->fs.xattr.value) + off, > + read_count); > + blob.size = read_count; > + > + err = pdu_marshal(pdu, offset, "dB", read_count, &blob); > + > + v9fs_blob_free(&blob); > + > if (err < 0) { > return err; > } > -- > 2.1.4