All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/4] drm/i915/bios: fix format string of the VBT signature logging
Date: Wed, 16 Dec 2015 18:10:51 +0200	[thread overview]
Message-ID: <87h9jis7as.fsf@intel.com> (raw)
In-Reply-To: <20151216142335.GU6851@nuc-i3427.alporthouse.com>

On Wed, 16 Dec 2015, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Wed, Dec 16, 2015 at 03:04:19PM +0200, Jani Nikula wrote:
>> Specify the maximum number of letters to print from the potentially
>> unterminated buffer, not the minimum. While at it, use sizeof instead of
>> a magic number.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Wow that's a widely underused feature, only the test code exercises.

I didn't know it was *that* underused!

All pushed to drm-intel-next-queued, thanks for the review!

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-12-16 16:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16 13:04 [PATCH 1/4] drm/i915: move drmP.h include to i915_drv.h Jani Nikula
2015-12-16 13:04 ` [PATCH 2/4] drm/i915/bios: fix format string of the VBT signature logging Jani Nikula
2015-12-16 14:23   ` Chris Wilson
2015-12-16 16:10     ` Jani Nikula [this message]
2015-12-16 13:04 ` [PATCH 3/4] drm/i915/bios: prefer using dev_priv over dev pointer Jani Nikula
2015-12-16 14:24   ` Chris Wilson
2015-12-16 13:04 ` [PATCH 4/4] drm/i915/bios: reduce indent in parse_general_features Jani Nikula
2015-12-16 14:24   ` Chris Wilson
2015-12-16 14:18 ` [PATCH 1/4] drm/i915: move drmP.h include to i915_drv.h Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h9jis7as.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.