From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 03/10] i915: Replace "hweight8(dev_priv->info.subslice_7eu[i]) != 1" with "!is_power_of_2(dev_priv->info.subslice_7eu[i])" Date: Mon, 07 Dec 2015 10:33:43 +0200 Message-ID: <87h9juzmhk.fsf@intel.com> References: <1449397590-14292-1-git-send-email-zhaoxiu.zeng@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1449397590-14292-1-git-send-email-zhaoxiu.zeng@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: daniel.vetter@intel.com, airlied@linux.ie, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Zeng Zhaoxiu List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCAwNiBEZWMgMjAxNSwgWmhhb3hpdSBaZW5nIDx6aGFveGl1LnplbmdAZ21haWwuY29t PiB3cm90ZToKPiBGcm9tOiBaZW5nIFpoYW94aXUgPHpoYW94aXUuemVuZ0BnbWFpbC5jb20+Cj4K PiBTaWduZWQtb2ZmLWJ5OiBaZW5nIFpoYW94aXUgPHpoYW94aXUuemVuZ0BnbWFpbC5jb20+CgpJ J2QgbGlrZSB0byBzZWUgYSBjb21taXQgbWVzc2FnZSBkZXNjcmliaW5nIHdoYXQgaXMgZG9uZSBh bmQgd2h5LCBldmVuCmZvciB0cml2aWFsIGNoYW5nZXMuIE5vdyB0aGUgc3ViamVjdCBsaW5lIGlz IGVzc2VudGlhbGx5IHRoZSBkaWZmIGluCnBsYWluIEVuZ2xpc2gsIHdoaWNoIGFkZHMgbm8gaW5m b3JtYXRpb24gdG8gdGhlIHBhdGNoIGl0c2VsZi4KCkl0IGRvZXNuJ3QgZXZlbiBzYXkgdGhhdCB0 aGlzIHNob3VsZCBiZSBhIG5vbi1mdW5jdGlvbmFsIGNoYW5nZS4KCkJSLApKYW5pLgoKCj4gLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYyB8IDMgKystCj4gIDEg ZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPgo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPiBpbmRleCA5NDYxYTIzLi4xNmM4Y2YxIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+IEBAIC0yNyw2ICsy Nyw3IEBACj4gICAqCj4gICAqLwo+ICAKPiArI2luY2x1ZGUgPGxpbnV4L2xvZzIuaD4KPiAgI2lu Y2x1ZGUgPGRybS9kcm1QLmg+Cj4gICNpbmNsdWRlICJpOTE1X2Rydi5oIgo+ICAjaW5jbHVkZSA8 ZHJtL2k5MTVfZHJtLmg+Cj4gQEAgLTEwMDAsNyArMTAwMSw3IEBAIHN0YXRpYyBpbnQgc2tsX3R1 bmVfaXpfaGFzaGluZyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nKQo+ICAJCSAqIE9ubHkg Y29uc2lkZXIgc2xpY2VzIHdoZXJlIG9uZSwgYW5kIG9ubHkgb25lLCBzdWJzbGljZSBoYXMgNwo+ ICAJCSAqIEVVcwo+ICAJCSAqLwo+IC0JCWlmIChod2VpZ2h0OChkZXZfcHJpdi0+aW5mby5zdWJz bGljZV83ZXVbaV0pICE9IDEpCj4gKwkJaWYgKCFpc19wb3dlcl9vZl8yKGRldl9wcml2LT5pbmZv LnN1YnNsaWNlXzdldVtpXSkpCj4gIAkJCWNvbnRpbnVlOwo+ICAKPiAgCQkvKgoKLS0gCkphbmkg TmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754775AbbLGIds (ORCPT ); Mon, 7 Dec 2015 03:33:48 -0500 Received: from mga03.intel.com ([134.134.136.65]:58067 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753102AbbLGIdr (ORCPT ); Mon, 7 Dec 2015 03:33:47 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,393,1444719600"; d="scan'208";a="868152138" From: Jani Nikula To: Zhaoxiu Zeng , daniel.vetter@intel.com, airlied@linux.ie, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Zeng Zhaoxiu Subject: Re: [PATCH 03/10] i915: Replace "hweight8(dev_priv->info.subslice_7eu[i]) != 1" with "!is_power_of_2(dev_priv->info.subslice_7eu[i])" In-Reply-To: <1449397590-14292-1-git-send-email-zhaoxiu.zeng@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1449397590-14292-1-git-send-email-zhaoxiu.zeng@gmail.com> User-Agent: Notmuch/0.20.2+101~gb57168b (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Mon, 07 Dec 2015 10:33:43 +0200 Message-ID: <87h9juzmhk.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 06 Dec 2015, Zhaoxiu Zeng wrote: > From: Zeng Zhaoxiu > > Signed-off-by: Zeng Zhaoxiu I'd like to see a commit message describing what is done and why, even for trivial changes. Now the subject line is essentially the diff in plain English, which adds no information to the patch itself. It doesn't even say that this should be a non-functional change. BR, Jani. > --- > drivers/gpu/drm/i915/intel_ringbuffer.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c > index 9461a23..16c8cf1 100644 > --- a/drivers/gpu/drm/i915/intel_ringbuffer.c > +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c > @@ -27,6 +27,7 @@ > * > */ > > +#include > #include > #include "i915_drv.h" > #include > @@ -1000,7 +1001,7 @@ static int skl_tune_iz_hashing(struct intel_engine_cs *ring) > * Only consider slices where one, and only one, subslice has 7 > * EUs > */ > - if (hweight8(dev_priv->info.subslice_7eu[i]) != 1) > + if (!is_power_of_2(dev_priv->info.subslice_7eu[i])) > continue; > > /* -- Jani Nikula, Intel Open Source Technology Center