From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35747)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Zyi9U-0001ln-Ne
	for qemu-devel@nongnu.org; Tue, 17 Nov 2015 10:26:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Zyi9P-0001BC-Q3
	for qemu-devel@nongnu.org; Tue, 17 Nov 2015 10:26:36 -0500
Received: from mx1.redhat.com ([209.132.183.28]:9311)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Zyi9P-0001B8-L5
	for qemu-devel@nongnu.org; Tue, 17 Nov 2015 10:26:31 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <1444739866-14798-1-git-send-email-berrange@redhat.com>
	<1444739866-14798-3-git-send-email-berrange@redhat.com>
	<563B8D06.8010803@suse.de>
Date: Tue, 17 Nov 2015 16:26:29 +0100
In-Reply-To: <563B8D06.8010803@suse.de> ("Andreas =?utf-8?Q?F=C3=A4rber=22?=
	=?utf-8?Q?'s?= message of "Thu, 5 Nov 2015 18:08:22 +0100")
Message-ID: <87h9kkodei.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 2/7] qmp: convert QMP code to use object
	property iterators
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Pavel Fedin <p.fedin@samsung.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

Andreas F=C3=A4rber <afaerber@suse.de> writes:

> Am 13.10.2015 um 14:37 schrieb Daniel P. Berrange:
>> Stop directly accessing the Object "properties" field data
>> structure and instead use the formal object property iterator
>> APIs. This insulates the code from future data structure
>> changes in the Object struct.
>>=20
>> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
>> ---
>>  qmp.c | 10 ++++++++--
>>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> Reviewed-by: Andreas F=C3=A4rber <afaerber@suse.de>
>
> Markus/Luiz, can you ack this change? Markus requested these iterators,
> I believe.

See my review of PATCH 1.