From: Jani Nikula <jani.nikula@linux.intel.com>
To: Thomas Wood <thomas.wood@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] intel_reg: ensure "intel_reg help" always works
Date: Wed, 09 Sep 2015 15:20:18 +0300 [thread overview]
Message-ID: <87h9n3n5rx.fsf@intel.com> (raw)
In-Reply-To: <1441640892-6778-1-git-send-email-thomas.wood@intel.com>
On Mon, 07 Sep 2015, Thomas Wood <thomas.wood@intel.com> wrote:
> Signed-off-by: Thomas Wood <thomas.wood@intel.com>
I'm lagging behind with my mails, and I see you already pushed
this... but care to explain the scenario where 'intel_reg help' does not
work? Should be part of the commit message...
BR,
Jani.
> ---
> tools/intel_reg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/intel_reg.c b/tools/intel_reg.c
> index 95760db..2b3c686 100644
> --- a/tools/intel_reg.c
> +++ b/tools/intel_reg.c
> @@ -865,7 +865,7 @@ int main(int argc, char *argv[])
> argc -= optind;
> argv += optind;
>
> - if (help)
> + if (help || (argc > 0 && strcmp(argv[0], "help") == 0))
> return intel_reg_help(&config, argc, argv);
>
> if (argc == 0) {
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-09 12:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 15:48 [PATCH i-g-t] intel_reg: ensure "intel_reg help" always works Thomas Wood
2015-09-09 12:20 ` Jani Nikula [this message]
2015-09-09 13:29 ` Thomas Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9n3n5rx.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thomas.wood@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.