From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNE4x-00084F-PY for qemu-devel@nongnu.org; Thu, 06 Aug 2015 01:51:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZNE4t-0002u5-NU for qemu-devel@nongnu.org; Thu, 06 Aug 2015 01:50:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51609) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNE4t-0002u1-Ij for qemu-devel@nongnu.org; Thu, 06 Aug 2015 01:50:55 -0400 From: Markus Armbruster References: <1438703896-12553-1-git-send-email-armbru@redhat.com> <1438703896-12553-11-git-send-email-armbru@redhat.com> <55C2287A.60401@redhat.com> Date: Thu, 06 Aug 2015 07:50:52 +0200 In-Reply-To: <55C2287A.60401@redhat.com> (Eric Blake's message of "Wed, 5 Aug 2015 09:15:06 -0600") Message-ID: <87h9odj77n.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH RFC v3 10/32] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, berto@igalia.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com Eric Blake writes: > On 08/04/2015 09:57 AM, Markus Armbruster wrote: >> Fixes flat unions to get the base's base members. Test case is from >> commit 2fc0043, in qapi-schema-test.json: >> > >> >> Flat union visitors remain broken. They'll be fixed next. >> >> Signed-off-by: Markus Armbruster >> --- >> docs/qapi-code-gen.txt | 51 +++--- > > Thanks for updating the docs. The diffstat of the actual generated code > is large, but the extra commits prove that in the end it's the same > material, just in different ordering. Meanwhile, the doc example is > correct, and being much shorter, makes it easier to see the sort of > reordering that happened. > >> scripts/qapi-types.py | 273 ++++++++++++++------------------ >> tests/qapi-schema/qapi-schema-test.json | 4 +- >> 3 files changed, 144 insertions(+), 184 deletions(-) >> > >> + >> +# If you link code generated from multiple schemata, you want only one >> +# instance include the code generated for built-in types. Generate it > > s/include/of/ Both phrasings parse fine for me :) Yours: you want it generated just once. Mine: you want only one generated instance include the code for built-in types. I'll go with "you want only one instance of the code for built-in types." >> +# only when do_builtins, enabled by command line option -b. See also >> +# QAPISchemaGenTypeVisitor.visit_end(). >> do_builtins = False > > With the grammar fix, > > Reviewed-by: Eric Blake Thanks!