All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/skl: Add module parameter to select	edp vswing table
Date: Tue, 05 May 2015 16:58:53 +0300	[thread overview]
Message-ID: <87h9rr6s82.fsf@intel.com> (raw)
In-Reply-To: <20150505130030.GC17367@strange.ger.corp.intel.com>

On Tue, 05 May 2015, Damien Lespiau <damien.lespiau@intel.com> wrote:
> On Tue, May 05, 2015 at 02:39:48PM +0300, Jani Nikula wrote:
>> There's still the question whether we can default to using the vbt value
>> if that can be broken...
>
> This is a workaround for SDPs loaded with a "default" VBT which doesn't
> correspond to the full fleet of SPDs. For actual product, it's really
> expected to have a VBT with a correct low vswing bit set, otherwise the
> panel won't lit up (even on Windows!).
>
> It's probably a good idea to add a comment saying that's it's a
> workaround for early platform with generic-ish VBT. Something that we
> should remove in a bit.

Thanks for the clarification, Damien. That settles the default then. I'd
still like the module parameter to be effective even if changed runtime.

BR,
Jani.



>
> -- 
> Damien

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-05-05 13:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-05  9:46 [PATCH] drm/i915/skl: Add module parameter to select edp vswing table Sonika Jindal
2015-05-05 11:39 ` Jani Nikula
2015-05-05 13:00   ` Damien Lespiau
2015-05-05 13:58     ` Jani Nikula [this message]
2015-05-06  5:43       ` Jindal, Sonika
2015-05-06  6:57         ` Jani Nikula
2015-05-06 10:13           ` Sonika Jindal
2015-05-06 10:28             ` Jani Nikula
2015-05-06 12:05               ` Sonika Jindal
2015-05-06 14:09                 ` Daniel Vetter
2015-05-07 12:27                 ` shuang.he
2015-05-07  9:15             ` shuang.he
2015-05-05 16:52 ` shuang.he

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h9rr6s82.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=damien.lespiau@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.