From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2] drm/i915: cope with large i2c transfers Date: Thu, 23 Apr 2015 23:53:21 +0300 Message-ID: <87h9s6woqm.fsf@intel.com> References: <20150421164911.GA6187@dtor-ws> <20150423161607.GN5082@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150423161607.GN5082@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Linus Torvalds Cc: David Airlie , intel-gfx , Dmitry Torokhov , Linux Kernel Mailing List , DRI , Nick Dyer , Olof Johansson , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAyMyBBcHIgMjAxNSwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90 ZToKPiBPbiBUdWUsIEFwciAyMSwgMjAxNSBhdCAxMDoxMjoxOUFNIC0wNzAwLCBMaW51cyBUb3J2 YWxkcyB3cm90ZToKPj4gT24gVHVlLCBBcHIgMjEsIDIwMTUgYXQgOTo0OSBBTSwgRG1pdHJ5IFRv cm9raG92Cj4+IDxkbWl0cnkudG9yb2tob3ZAZ21haWwuY29tPiB3cm90ZToKPj4gPiBUaGUgaGFy ZHdhcmUsIGFjY29yZGluZyB0byB0aGUgc3BlY3MsIGlzIGxpbWl0ZWQgdG8gMjU2IGJ5dGUgdHJh bnNmZXJzLAo+PiA+IGFuZCBjdXJyZW50IGRyaXZlciBoYXMgbm8gcHJvdGVjdGlvbnMgaW4gY2Fz ZSB1c2VycyBhdHRlbXB0IHRvIGRvIGxhcmdlcgo+PiA+IHRyYW5zZmVycy4gVGhlIGNvZGUgd2ls bCBqdXN0IHN0b21wIG92ZXIgc3RhdHVzIHJlZ2lzdGVyIGFuZCBtYXloZW0KPj4gPiBlbnN1ZXMu Cj4+IAo+PiBUaGFua3MsIGxvb2tzIGdvb2QuCj4+IAo+PiBEYXZpZC9EYW5pZWwgLSBzaG91bGQg SSB0YWtlIHRoaXMgZGlyZWN0bHksIG9yIGNhbiBJIGV4cGVjdCB0byBqdXN0Cj4+IGdldCBpdCBm cm9tIHRoZSBkcm0gdHJlZT8KPgo+IEkgYXNrZWQgSmFuaSB0byBwaWNrIHRoaXMgdXAuIEknbSBo b3JyaWJseSBqZXRsYWdnZWQgYW5kIGp1c3QgcmVwYWNraW5nCj4gZm9yIG15IHZhY2F0aW9uIHNv IHByb2JhYmx5IHNob3VsZG4ndCB0b3VjaCBnaXQgYnJhbmNoZXMgcmlnaHQgbm93IDstKQoKUHVz aGVkIHRvIGRybS1pbnRlbC1uZXh0LWZpeGVzLCB0aGFua3MgZm9yIHRoZSBwYXRjaCBhbmQgcmV2 aWV3LiBJJ2xsCmdhdGhlciBhIGZldyBtb3JlIGZpeGVzIGFuZCBzZW5kIHRoZSBwdWxsIHJlcSB0 byBEYXZlIGxhdGVyLgoKQlIsCkphbmkuCgoKPiAtRGFuaWVsCj4gLS0gCj4gRGFuaWVsIFZldHRl cgo+IFNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgo+IGh0dHA6Ly9ibG9nLmZm d2xsLmNoCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K PiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y Zwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030930AbbDWUvf (ORCPT ); Thu, 23 Apr 2015 16:51:35 -0400 Received: from mga11.intel.com ([192.55.52.93]:24095 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030855AbbDWUva (ORCPT ); Thu, 23 Apr 2015 16:51:30 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,634,1422950400"; d="scan'208";a="714544553" From: Jani Nikula To: Daniel Vetter , Linus Torvalds Cc: David Airlie , intel-gfx , Dmitry Torokhov , Linux Kernel Mailing List , Nick Dyer , DRI , Olof Johansson , Daniel Vetter Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: cope with large i2c transfers In-Reply-To: <20150423161607.GN5082@phenom.ffwll.local> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20150421164911.GA6187@dtor-ws> <20150423161607.GN5082@phenom.ffwll.local> User-Agent: Notmuch/0.19+87~gcf99a78 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Thu, 23 Apr 2015 23:53:21 +0300 Message-ID: <87h9s6woqm.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 23 Apr 2015, Daniel Vetter wrote: > On Tue, Apr 21, 2015 at 10:12:19AM -0700, Linus Torvalds wrote: >> On Tue, Apr 21, 2015 at 9:49 AM, Dmitry Torokhov >> wrote: >> > The hardware, according to the specs, is limited to 256 byte transfers, >> > and current driver has no protections in case users attempt to do larger >> > transfers. The code will just stomp over status register and mayhem >> > ensues. >> >> Thanks, looks good. >> >> David/Daniel - should I take this directly, or can I expect to just >> get it from the drm tree? > > I asked Jani to pick this up. I'm horribly jetlagged and just repacking > for my vacation so probably shouldn't touch git branches right now ;-) Pushed to drm-intel-next-fixes, thanks for the patch and review. I'll gather a few more fixes and send the pull req to Dave later. BR, Jani. > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center