All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/i915: Wait for render state init
Date: Mon, 16 Mar 2015 16:20:46 +0200	[thread overview]
Message-ID: <87h9tlm3b5.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20150316135125.GC27819@nuc-i3427.alporthouse.com>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> On Mon, Mar 16, 2015 at 03:46:34PM +0200, Mika Kuoppala wrote:
>> We are freeing the batch that is just pushed to ring.
>
> Kill this. It is not correct.
>
>> Further, other ring inits should assume that the render
>> context with the workarounds are pushed before their rings
>> execute anything.
>> 
>> This fixes (or papers over) a problem where with full ppgtt
>> the blitter ring init sometimes fails, where the blt ring
>> ACTHD runs wild through the address space until eventually
>> hangcheck kills it.
>
> Interesting. We don't do anything inside the golden render state to be
> of relevance to the blitter engine. So I think this is pure paper and
> will not ultimately fix the problem.
> -Chris
>

Perhaps not in the golden state, but do we push any workarounds through
render ring init, that are global in scope and required by the other rings?

-Mika
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-03-16 14:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16 13:46 [PATCH 0/3] ring/context initialization patches Mika Kuoppala
2015-03-16 13:46 ` [PATCH 1/3] drm/i915: Wait for render state init Mika Kuoppala
2015-03-16 13:51   ` Chris Wilson
2015-03-16 14:20     ` Mika Kuoppala [this message]
2015-03-16 14:38       ` Chris Wilson
2015-03-16 15:56         ` Mika Kuoppala
2015-03-16 15:58           ` [PATCH] drm/i915: Push mm switch immediately to ring Mika Kuoppala
2015-03-16 21:35             ` Chris Wilson
2015-03-17 16:10               ` Mika Kuoppala
2015-03-16 13:46 ` [PATCH 2/3] drm/i915: Detect page faults during hangcheck Mika Kuoppala
2015-03-16 17:53   ` Daniel Vetter
2015-03-16 21:30     ` Chris Wilson
2015-03-17 10:31       ` Daniel Vetter
2015-03-16 13:46 ` [PATCH 3/3] drm/i915: Reorder hw init to avoid executing with invalid context/mm state Mika Kuoppala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h9tlm3b5.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.