Re: [Qemu-devel] [PATCH 1/5] 9pfs-proxy: simplify v9fs_request(), P1

["Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>]

Michael Tokarev <mjt@tls.msk.ru> writes:

> 08.03.2015 19:39, Aneesh Kumar K.V wrote:
>> Michael Tokarev <mjt@tls.msk.ru> writes:
>> 
>>> This simplifies code in v9fs_request() a bit by replacing several
>>> ifs with a common variable check and rearranging error/cleanup
>>> code a bit.
>> 
>> Is this -V2 of
>> http://mid.gmane.org/b98f675750ef0535cab41225240db1657fc2fe00.1425678142.git.mjt@msgid.tls.msk.ru
>
> No, this one (simplify v9fs_reqeust(), P1) was a first version.
> The above URL points to the v2, a second version.

Please post an update patch series with the variable rename and the v9fs
simplification as two different patches.


>
>> I am slightly confused with the patch series. It does split the patch as
>> I wanted, but i am not sure which one is the latest, so that i can start
>> applying them.
>
> That URL points to last.  I merged several small patches into larger ones.
>
> Initially I thought I just plug a small resource leak so the patch will
> be small.  But the more I understood the code, the bigger the changes
> were becoming.  So at some point it become unreasonable to keep small
> changes since they're related to bigger changes and since bigger changes
> touches the same code anyway.
>

Please keep the patches smaller. If needed i can fold them up when
merging the changes.

-aneesh