From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: My minnow was broken by: drm/i915: Consolidate forcewake code Date: Mon, 26 Jan 2015 10:34:41 +0200 Message-ID: <87h9vegcta.fsf@intel.com> References: <20150124115819.GG10113@phenom.ffwll.local> <20150124153744.GZ19354@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 03B946E217 for ; Mon, 26 Jan 2015 00:33:53 -0800 (PST) In-Reply-To: <20150124153744.GZ19354@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville =?utf-8?B?U3lyasOkbMOk?= , Daniel Vetter Cc: Darren Hart , "dvhart@dvhart.com" , mika.kuoppal@intel.com, DRI mailing list , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCAyNCBKYW4gMjAxNSwgVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4gd3JvdGU6Cj4gT24gU2F0LCBKYW4gMjQsIDIwMTUgYXQgMTI6NTg6MTlQTSAr MDEwMCwgRGFuaWVsIFZldHRlciB3cm90ZToKPj4gT24gRnJpLCBKYW4gMjMsIDIwMTUgYXQgMDI6 NDM6NTNQTSAtMDgwMCwgRGFycmVuIEhhcnQgd3JvdGU6Cj4+ID4gK0phbmkKPj4gPiAKPj4gPiBK YW5pLCBJIHRoaW5rIHRoaXMgbWF5IGhhdmUgaW5hZHZlcnRlbnRseSB1bmRvbmUgdGhlIGZpeCB5 b3UgbWFkZSBmb3IKPj4gPiB1cyBvbiB0aGUgTWlubm93TWF4Lgo+PiAKPj4gRG8geW91IHN0aWxs IHJlbWVtYmVyIHRoZSBwYXRjaD8gU29tZSBkaWdnaW5nIGFyb3VuZCBkaWRuJ3QgdHVybiB1cAo+ PiBhbnl0aGluZyAuLi4KPgo+IElJUkMgaXQgd2FzIHRoaXM6Cj4gY29tbWl0IDA1YWRhZjFmMTAx ZjI1ZjQwZjEyYzI5NDAzZTY0ODhmMGU0NWY2YjYKPiBBdXRob3I6IEphbmkgTmlrdWxhIDxqYW5p Lm5pa3VsYUBpbnRlbC5jb20+Cj4gRGF0ZTogICBGcmkgTWF5IDkgMTQ6NTI6MzQgMjAxNCArMDMw MAo+Cj4gICAgIGRybS9pOTE1L3ZsdjogcmVzZXQgVkxWIG1lZGlhIGZvcmNlIHdha2UgcmVxdWVz dCByZWdpc3RlcgoKVGhhdCdzIHRoZSBmaXggYWxsIHJpZ2h0LgoKSG93ZXZlciB0aGVyZSdzCgpb ICAgIDIuMDMyMDc1XSBbZHJtXSBmYWlsZWQgdG8gcmV0cmlldmUgbGluayBpbmZvLCBkaXNhYmxp bmcgZURQCgppbiB0aGUgbG9ncyBzdWdnZXN0aW5nIHRoZSBtaW5ub3dtYXggdHJpZXMgdG8gaW5p dGlhbGl6ZSBlRFAgd2hpY2ggaXQKZG9lc24ndCBoYXZlLiBUaGF0J3MgYSBWQlQgcHJvYmxlbSBp biBpdHNlbGYsIGJ1dCBzaW5jZQoKY29tbWl0IGQyMTgyYTY2MDgwOGQ5MDUzYTYwNWUzZWJjOGM0 NmEzMjNlYzZlNWQKQXV0aG9yOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXgu aW50ZWwuY29tPgpEYXRlOiAgIEZyaSBKYW4gOSAxNDoyMToxNCAyMDE1ICswMjAwCgogICAgZHJt L2k5MTU6IERvbid0IHJlZ2lzdGVyIEhETUkgY29ubmVjdG9ycyBmb3IgZURQIHBvcnRzIG9uIFZM Vi9DSFYKCndlIGRvbid0IHJlZ2lzdGVyIEhETUkgaWYgdGhlcmUncyBhbiBlRFAgaW4gdGhlIHNh bWUgcG9ydC4uLgoKUG90ZW50aWFsbHkgdHdvIHByb2JsZW1zIEkgdGhpbmsuCgpCUiwKSmFuaS4K CgoKPgo+PiAtRGFuaWVsCj4+IAo+PiA+IAo+PiA+IE9uIEZyaSwgSmFuIDIzLCAyMDE1IGF0IDE6 NDQgUE0sIE9sb2YgSm9oYW5zc29uIDxvbG9mQGxpeG9tLm5ldD4gd3JvdGU6Cj4+ID4gPiBIaSBE YW5pZWwsIE1pa2EsCj4+ID4gPgo+PiA+ID4gRm9yIHRoZSBmaXJzdCB0aW1lIGluIGEgZmV3IGRh eXMsIC1uZXh0IHdhcyBib290YWJsZSBsYXN0IG5pZ2h0LiBJCj4+ID4gPiBub3RpY2VkIHRoYXQg bXkgTWlubm93Ym9hcmQgTWF4IGRpZG4ndCBhY3R1YWxseSBib290IHRob3VnaCwgaXQgZ290Cj4+ ID4gPiBzdHVjayBzaG9ydGx5IGFmdGVyIG9yIGR1cmluZyBEUk0gcHJvYmluZzoKPj4gPiA+Cj4+ ID4gPiBodHRwOi8vYXJtLXNvYy5saXhvbS5uZXQvYm9vdGxvZ3MvbmV4dC9uZXh0LTIwMTUwMTIz L21pbm5vd21heC14ODYtbWlubm93bWF4X2RlZmNvbmZpZy5odG1sCj4+ID4gPgo+PiA+ID4gSSBi aXNlY3RlZCBpdCBkb3duIHRvIHRoZSBiZWxvdyBwYXRjaCB0aGF0IEkgZmFpbGVkIHRvIGZpbmQg cG9zdGVkCj4+ID4gPiAod2l0aCB0aGF0IHN1YmplY3QpIGFueXdoZXJlIG9uIGEgcHVibGljIGxp c3QgdGhhdCBJIGFtIHN1YnNjcmliZWQgdG8uCj4+ID4gPgo+PiA+ID4gVGhlIHBhdGNoIGlzbid0 IHJldmVydGFibGUgd2l0aG91dCBjb25zaWRlcmFibGUgZWZmb3J0IHNvIEkgY2FuJ3QKPj4gPiA+ IGRvdWJsZSBjaGVjayB0aGF0IGl0J3MganVzdCB0aGlzIG9uZSBjaGFuZ2UsIGJ1dCB0aGUgY29t bWl0IGJlZm9yZQo+PiA+ID4gdGhhdCBpbiB0aGUgYnJhbmNoIGJvb3RzLCB0aGlzIG9uZSBkb2Vz IG5vdC4KPj4gPiA+Cj4+ID4gPgo+PiA+ID4gY29tbWl0IGZjNzIzNTVmNWMwNGM0MGYyOTE2YTA3 ZTlmOGQ0YjM1N2UyZTBhOTMKPj4gPiA+IEF1dGhvcjogICAgIE1pa2EgS3VvcHBhbGEgPG1pa2Eu a3VvcHBhbGFAbGludXguaW50ZWwuY29tPgo+PiA+ID4gQXV0aG9yRGF0ZTogTW9uIEphbiAxOSAx NjoyMDo0MyAyMDE1ICswMjAwCj4+ID4gPiBDb21taXQ6ICAgICBEYW5pZWwgVmV0dGVyIDxkYW5p ZWwudmV0dGVyQGZmd2xsLmNoPgo+PiA+ID4gQ29tbWl0RGF0ZTogVHVlIEphbiAyMCAxMjozNjo1 NyAyMDE1ICswMTAwCj4+ID4gPgo+PiA+ID4gICAgIGRybS9pOTE1OiBDb25zb2xpZGF0ZSBmb3Jj ZXdha2UgY29kZQo+PiA+ID4KPj4gPiA+ICAgICBBcyB3ZSBub3cgaGF2ZSBmb3JjZXdha2UgZG9t YWlucywgdGFrZSBhZHZhbnRhZ2Ugb2YgaXQKPj4gPiA+ICAgICBieSBwdXR0aW5nIHRoZSBkaWZm ZXJlbmNlcyBpbiBnZW4gZncgaGFuZGxpbmcgaW4gZGF0YSByYXRoZXIKPj4gPiA+ICAgICB0aGFu IGluIGNvZGUuCj4+ID4gPgo+PiA+ID4gICAgIEluIHBhc3Qgd2UgaGF2ZSBvcGVuY29kZWQgdGhp cyBxdWl0ZSBleHRlbnNpdmVseSBhcyB0aGUgZncgaGFuZGxpbmcKPj4gPiA+ICAgICBpcyBpbiB0 aGUgZmFzdCBwYXRoLiBUaGVyZSBoYXMgYWxzbyBiZWVuIGEgbG90IG9mIGNhcmdvLWN1bHRlZAo+ PiA+ID4gICAgIGNvcHknbidwYXN0aW5nIGZyb20gb2xkZXIgZ2VucyB0byBuZXdlciBvbmVzLgo+ PiA+ID4KPj4gPiA+ICAgICBOb3cgd2hlbiB0aGUgcmVsZWFzaW5nIG9mIHRoZSBmb3JjZXdha2Ug aXMgZG9uZSBieSBkZWZlcnJlZCB0aW1lciwKPj4gPiA+ICAgICBpdCBnaXZlcyBjaGFuY2UgdG8g Y29uc29saWRhdGUgbW9yZS4gRHVlIHRvIHRoZSBmcmVxdWVuY3kgb2YgYWN0dWFsIGh3Cj4+ID4g PiAgICAgYWNjZXNzIGJlaW5nIHNpZ25pZmljYW50bHkgbGVzcy4KPj4gPiA+Cj4+ID4gPiAgICAg VGFrZSBhZHZhbnRhZ2Ugb2YgdGhpcyBhbmQgZ2VuZXJhbGl6ZSB0aGUgZncgaGFuZGxpbmcgY29k ZQo+PiA+ID4gICAgIGFzIG11Y2ggYXMgcG9zc2libGUuIEJ1dCB3ZSBzdGlsbCBhaW0gdG8ga2Vl cCB0aGUgZm9yY2V3YWtlIHNlcXVlbmNlCj4+ID4gPiAgICAgcGFydGljdWxhcml0aWVzIGZvciBl YWNoIGdlbiBpbnRhY3QuIFNvIHRoZSBhY2Nlc3MgcGF0dGVybgo+PiA+ID4gICAgIHRvIGZ3IGVu Z2luZXMgc2hvdWxkIHJlbWFpbiB0aGUgc2FtZS4KPj4gPiA+Cj4+ID4gPiAgICAgdjI6IC0gcy9v bGRfYWNrL2NsZWFyX2FjayAoQ2hyaXMpCj4+ID4gPiAgICAgICAgIC0gcy9wb3N0X3JlYWQvcG9z dGluZ19yZWFkIChDaHJpcykKPj4gPiA+ICAgICAgICAgLSBsZXNzIHBvbGl0ZSBjb21taXQgbXNn IChDaHJpcykKPj4gPiA+Cj4+ID4gPiAgICAgdjM6IC0gcmViYXNlCj4+ID4gPiAgICAgICAgIC0g Y2hlY2sgYW5kIGNsZWFyIHdha2VfY291bnQgaW4gaW5pdAo+PiA+ID4KPj4gPiA+ICAgICB2NDog LSBmaXggcG9zdGluZyByZWFkcyBmb3IgZ2VuOCAoUFJUUykKPj4gPiA+Cj4+ID4gPiAgICAgU2ln bmVkLW9mZi1ieTogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBpbnRlbC5jb20+Cj4+ID4g PiAgICAgUmV2aWV3ZWQtYnk6IERlZXBhayBTIDxkZWVwYWsuc0BsaW51eC5pbnRlbC5jb20+ICh2 MikKPj4gPiA+ICAgICBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVy QGZmd2xsLmNoPgo+PiA+IAo+PiA+IAo+PiA+IAo+PiA+IC0tIAo+PiA+IERhcnJlbiBIYXJ0Cj4+ IAo+PiAtLSAKPj4gRGFuaWVsIFZldHRlcgo+PiBTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29y cG9yYXRpb24KPj4gKzQxICgwKSA3OSAzNjUgNTcgNDggLSBodHRwOi8vYmxvZy5mZndsbC5jaAo+ PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+PiBkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0Cj4+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPj4g aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo+ Cj4gLS0gCj4gVmlsbGUgU3lyasOkbMOkCj4gSW50ZWwgT1RDCj4gX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4g ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwg T3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK