From mboxrd@z Thu Jan 1 00:00:00 1970 From: arno@natisbad.org (Arnaud Ebalard) Date: Thu, 15 Jan 2015 09:02:23 +0100 Subject: [PATCHv0 2/3] rtc: Add support for Abracon AB-RTCMC-32.768kHz-B5ZE-S3 I2C RTC chip In-Reply-To: <20150114170343.6f8d807a.akpm@linux-foundation.org> (Andrew Morton's message of "Wed, 14 Jan 2015 17:03:43 -0800") References: <1ae63ab80cfb39305884bd0c2648a420ba3bc0a5.1421045942.git.arno@natisbad.org> <20150114165557.d44c5752.akpm@linux-foundation.org> <20150114170343.6f8d807a.akpm@linux-foundation.org> Message-ID: <87h9vsqxo0.fsf@natisbad.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Andrew, Andrew Morton writes: > On Wed, 14 Jan 2015 16:55:57 -0800 Andrew Morton wrote: > >> Something like this? > > Leading to changes in [3/3]. Please have a think about where we should > be calling device_init_wakeup(dev, false) on the error recovery path. > > Let me know if I should just drop it all and await a v2... I'll work on a v2 to handle your comments and suggestions. I will also take into account the other comment I got regarding the use of "abracon" instead of "abcn" as vendor prefix for Abracon Corporation. Thanks for the review. a+ From mboxrd@z Thu Jan 1 00:00:00 1970 From: arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org (Arnaud Ebalard) Subject: Re: [PATCHv0 2/3] rtc: Add support for Abracon AB-RTCMC-32.768kHz-B5ZE-S3 I2C RTC chip Date: Thu, 15 Jan 2015 09:02:23 +0100 Message-ID: <87h9vsqxo0.fsf@natisbad.org> References: <1ae63ab80cfb39305884bd0c2648a420ba3bc0a5.1421045942.git.arno@natisbad.org> <20150114165557.d44c5752.akpm@linux-foundation.org> <20150114170343.6f8d807a.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20150114170343.6f8d807a.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> (Andrew Morton's message of "Wed, 14 Jan 2015 17:03:43 -0800") Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andrew Morton Cc: Mark Rutland , Alessandro Zummo , Peter Huewe , Linus Walleij , Thierry Reding , Mark Brown , Arnd Bergmann , Rob Herring , Pawel Moll , Stephen Warren , Ian Campbell , Grant Likely , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Landley , rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Jason Cooper , Guenter Roeck , Jason Gunthorpe , Kumar Gala , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Andrew, Andrew Morton writes: > On Wed, 14 Jan 2015 16:55:57 -0800 Andrew Morton wrote: > >> Something like this? > > Leading to changes in [3/3]. Please have a think about where we should > be calling device_init_wakeup(dev, false) on the error recovery path. > > Let me know if I should just drop it all and await a v2... I'll work on a v2 to handle your comments and suggestions. I will also take into account the other comment I got regarding the use of "abracon" instead of "abcn" as vendor prefix for Abracon Corporation. Thanks for the review. a+ -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html