From: Markus Armbruster <armbru@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: jsnow@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] ide: Check validity of logical block size
Date: Wed, 03 Dec 2014 15:37:23 +0100 [thread overview]
Message-ID: <87h9xckdek.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1417610103-18234-1-git-send-email-kwolf@redhat.com> (Kevin Wolf's message of "Wed, 3 Dec 2014 13:35:03 +0100")
Kevin Wolf <kwolf@redhat.com> writes:
> Our IDE emulation can't handle logical block sizes other than 512. Check
> for it.
I guess this is in part due to the 512 literals sprinkled all over the
IDE code.
> The original assumption was that other values would silently be ignored
> (which is bad enough), but it's not quite true: The physical block size
> is exposed in IDENTIFY DEVICE as a multiple of the logical block size.
> Setting a logical block size therefore also corrupts the physical block
> size (4096/4096 doesn't silently downgrade to 4096/512, but 512/512).
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2014-12-03 14:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 12:35 [Qemu-devel] [PATCH] ide: Check validity of logical block size Kevin Wolf
2014-12-03 14:37 ` Markus Armbruster [this message]
2014-12-03 14:50 ` Kevin Wolf
2014-12-03 14:45 ` John Snow
2014-12-03 14:53 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9xckdek.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.