From: Jani Nikula <jani.nikula@linux.intel.com>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] lib: fix #define max
Date: Wed, 22 Oct 2014 21:32:23 +0300 [thread overview]
Message-ID: <87h9ywgdl4.fsf@intel.com> (raw)
In-Reply-To: <1413906580-4840-1-git-send-email-mika.kuoppala@intel.com>
On Tue, 21 Oct 2014, Mika Kuoppala <mika.kuoppala@linux.intel.com> wrote:
> Regression from:
>
> commit be4710a541b517b5f8663448bffed5656d59b47b
> Author: Thomas Wood <thomas.wood@intel.com>
> Date: Fri Oct 10 11:20:35 2014 +0100
>
> lib: add common min and max macros
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85218
> Tested-by: Guo Jinxian <jinxianx.guo@intel.com>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
Push it already!
> ---
> lib/igt_aux.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/igt_aux.h b/lib/igt_aux.h
> index 415614b..9b42918 100644
> --- a/lib/igt_aux.h
> +++ b/lib/igt_aux.h
> @@ -85,6 +85,6 @@ bool intel_check_memory(uint32_t count, uint32_t size, unsigned mode);
>
>
> #define min(a, b) ((a) < (b) ? (a) : (b))
> -#define max(a, b) ((a) < (b) ? (a) : (b))
> +#define max(a, b) ((a) > (b) ? (a) : (b))
>
> #endif /* IGT_AUX_H */
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-10-22 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 15:49 [PATCH] lib: fix #define max Mika Kuoppala
2014-10-22 18:32 ` Jani Nikula [this message]
2014-10-23 12:19 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2014-10-21 13:31 Mika Kuoppala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9ywgdl4.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.