From: Juan Quintela <quintela@redhat.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: mst@redhat.com, QEMU Trivial <qemu-trivial@nongnu.org>,
mjt@tls.msk.ru, QEMU Developers <qemu-devel@nongnu.org>,
owasserm@redhat.com, pbonzini@redhat.com,
Eric Blake <eblake@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH] arch_init: Simplify code for load_xbzrle()
Date: Mon, 12 May 2014 12:27:38 +0200 [thread overview]
Message-ID: <87ha4v8f6t.fsf@elfo.mitica> (raw)
In-Reply-To: <536E20CC.4030401@gmail.com> (Chen Gang's message of "Sat, 10 May 2014 20:51:24 +0800")
Chen Gang <gang.chen.5i5j@gmail.com> wrote:
> For xbzrle_decode_buffer(), when decoding contents will exceed writing
> buffer, it will return -1, so need not check the return value whether
> large than writing buffer.
>
> And when failure occurs within load_xbzrle(), it always return -1
> without any resources which need release.
>
> So can remove the related checking statements, and also can remove 'rc'
> and 'ret' local variables,
>
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Juan Quintela <quintela@redhat.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: mst@redhat.com, QEMU Trivial <qemu-trivial@nongnu.org>,
mjt@tls.msk.ru, QEMU Developers <qemu-devel@nongnu.org>,
owasserm@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] arch_init: Simplify code for load_xbzrle()
Date: Mon, 12 May 2014 12:27:38 +0200 [thread overview]
Message-ID: <87ha4v8f6t.fsf@elfo.mitica> (raw)
In-Reply-To: <536E20CC.4030401@gmail.com> (Chen Gang's message of "Sat, 10 May 2014 20:51:24 +0800")
Chen Gang <gang.chen.5i5j@gmail.com> wrote:
> For xbzrle_decode_buffer(), when decoding contents will exceed writing
> buffer, it will return -1, so need not check the return value whether
> large than writing buffer.
>
> And when failure occurs within load_xbzrle(), it always return -1
> without any resources which need release.
>
> So can remove the related checking statements, and also can remove 'rc'
> and 'ret' local variables,
>
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2014-05-12 10:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-10 12:51 [Qemu-trivial] [PATCH] arch_init: Simplify code for load_xbzrle() Chen Gang
2014-05-10 12:51 ` [Qemu-devel] " Chen Gang
2014-05-12 10:27 ` Juan Quintela [this message]
2014-05-12 10:27 ` Juan Quintela
2014-05-17 7:54 ` [Qemu-trivial] " Michael Tokarev
2014-05-17 7:54 ` [Qemu-devel] " Michael Tokarev
2014-05-18 10:53 ` Chen Gang
2014-05-18 10:53 ` [Qemu-devel] " Chen Gang
2014-05-19 7:46 ` Michael Tokarev
2014-05-19 7:46 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ha4v8f6t.fsf@elfo.mitica \
--to=quintela@redhat.com \
--cc=eblake@redhat.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=owasserm@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.