From: Markus Armbruster <armbru@redhat.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Peter Maydell <peter.maydell@linaro.org>,
Michael Tokarev <mjt@tls.msk.ru>,
QEMU Developers <qemu-devel@nongnu.org>,
Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH trivial v2 0/2] vl: simplify code for main()
Date: Wed, 16 Apr 2014 09:04:38 +0200 [thread overview]
Message-ID: <87ha5t21rt.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <534DC6EA.6050203@gmail.com> (Chen Gang's message of "Wed, 16 Apr 2014 07:55:22 +0800")
Chen Gang <gang.chen.5i5j@gmail.com> writes:
> In "vl.c", at least, we can simplify the code below, so can let readers
> read professional C code (especially for new readers, which often start
> reading code at main function).
>
> - Remove useless 'continue' in main().
>
> - Eliminate a superfluous local variable in main().
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2014-04-16 7:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 23:55 [Qemu-trivial] [PATCH trivial v2 0/2] vl: simplify code for main() Chen Gang
2014-04-15 23:56 ` [Qemu-trivial] [PATCH trivial v2 1/2] vl: Remove useless 'continue' Chen Gang
2014-04-15 23:57 ` [Qemu-trivial] [PATCH trivial v2 2/2] vl: Eliminate a superfluous local variable Chen Gang
2014-04-16 7:04 ` Markus Armbruster [this message]
2014-04-24 13:57 ` [Qemu-trivial] [PATCH trivial v2 0/2] vl: simplify code for main() Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ha5t21rt.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=aliguori@amazon.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.