From: David Kastrup <dak@gnu.org>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] cache_tree_find(): remove redundant checks
Date: Tue, 04 Mar 2014 11:34:39 +0100 [thread overview]
Message-ID: <87ha7ei75s.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <5315A974.5000104@alum.mit.edu> (Michael Haggerty's message of "Tue, 04 Mar 2014 11:22:44 +0100")
Michael Haggerty <mhagger@alum.mit.edu> writes:
> BTW, I purposely didn't use a "for" loop at the end (even though I
> usually like them) because I wanted to keep it prominent that path is
> being updated to the value of slash. Putting that assignment in a for
> loop makes it easy to overlook because it puts "path" in the spot that
> usually holds an inconsequential iteration variable.
Reasonable.
--
David Kastrup
next prev parent reply other threads:[~2014-03-04 10:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 8:31 [PATCH v2] cache_tree_find(): remove redundant checks Michael Haggerty
2014-03-04 9:40 ` David Kastrup
2014-03-04 10:22 ` Michael Haggerty
2014-03-04 10:34 ` David Kastrup [this message]
2014-03-04 21:05 ` Junio C Hamano
2014-03-04 22:24 ` Michael Haggerty
2014-03-04 23:18 ` Junio C Hamano
2014-03-05 17:57 ` Junio C Hamano
2014-03-05 4:38 ` David Kastrup
2014-03-05 18:40 ` Junio C Hamano
2014-03-04 21:11 ` [microproject idea] Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ha7ei75s.fsf@fencepost.gnu.org \
--to=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.