From: David Kastrup <dak@gnu.org>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] builtin/blame.c::prepare_lines: fix allocation size of sb->lineno
Date: Sat, 08 Feb 2014 22:34:42 +0100 [thread overview]
Message-ID: <87ha89b85p.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <20140208212154.GA4283@sigill.intra.peff.net> (Jeff King's message of "Sat, 8 Feb 2014 16:21:54 -0500")
Jeff King <peff@peff.net> writes:
> However, is there a reason not to use:
>
> sizeof(*sb->lineno)
>
> rather than
>
> sizeof(int)
>
> to avoid type-mismatch errors entirely (this applies both to this patch,
> and to any proposed rewrites using malloc).
It deviates from the style of the original code by tried and true Git
developers. So feel free to roll your own patch here: it's not like
this one has any copyrightable content in it.
--
David Kastrup
prev parent reply other threads:[~2014-02-08 21:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-08 9:19 [PATCH] builtin/blame.c::prepare_lines: fix allocation size of sb->lineno David Kastrup
2014-02-08 9:49 ` David Kastrup
2014-02-08 21:21 ` Jeff King
2014-02-08 21:34 ` David Kastrup [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ha89b85p.fsf@fencepost.gnu.org \
--to=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.