From: Thomas Rast <trast@inf.ethz.ch>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: <git@vger.kernel.org>, <gitster@pobox.com>
Subject: Re: [PATCH] die_with_status: use "printf '%s\n'", not "echo"
Date: Wed, 7 Aug 2013 11:48:20 +0200 [thread overview]
Message-ID: <87haf1vnkr.fsf@linux-k42r.v.cablecom.net> (raw)
In-Reply-To: <vpqy58dj1ly.fsf@anie.imag.fr> (Matthieu Moy's message of "Wed, 07 Aug 2013 11:23:37 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> Thomas Rast <trast@inf.ethz.ch> writes:
>
>>> + grep -v " " error
>>
>> Umm, doesn't that only test that _some_ line in the error does not
>> contain a tab?
>
> Indeed. It does work as the error message is just a one-liner, but let's
> be robust anyway.
Err, right. I actually applied the patch and verified that the test
"erroneously" passed without the fix, but that's simply because I use
bash instead of dash. The error message indeed is only one line, the
rest of the rebase output goes to stdout.
--
Thomas Rast
trast@{inf,student}.ethz.ch
prev parent reply other threads:[~2013-08-07 9:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 15:44 git rebase -i error message interprets \t in commit message David Kastrup
2013-08-06 16:01 ` Ramkumar Ramachandra
2013-08-06 17:47 ` Junio C Hamano
2013-08-06 16:05 ` Matthieu Moy
2013-08-06 17:07 ` David Kastrup
2013-08-06 17:19 ` Matthieu Moy
2013-08-06 19:23 ` David Kastrup
2013-08-06 19:35 ` Junio C Hamano
2013-08-06 17:52 ` Junio C Hamano
2013-08-06 18:26 ` [PATCH] die_with_status: use "printf '%s\n'", not "echo" Matthieu Moy
2013-08-07 8:58 ` Thomas Rast
2013-08-07 9:23 ` Matthieu Moy
2013-08-07 9:26 ` [PATCH v2] " Matthieu Moy
2013-08-07 9:48 ` Thomas Rast [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87haf1vnkr.fsf@linux-k42r.v.cablecom.net \
--to=trast@inf.ethz.ch \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.