From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59277)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1UIim6-0007vK-Bn
	for qemu-devel@nongnu.org; Thu, 21 Mar 2013 12:55:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1UIily-0000fQ-8G
	for qemu-devel@nongnu.org; Thu, 21 Mar 2013 12:55:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50740)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1UIilx-0000f8-Va
	for qemu-devel@nongnu.org; Thu, 21 Mar 2013 12:55:26 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1363881940-27505-3-git-send-email-owasserm@redhat.com> (Orit
	Wasserman's message of "Thu, 21 Mar 2013 18:05:33 +0200")
References: <1363881940-27505-1-git-send-email-owasserm@redhat.com>
	<1363881940-27505-3-git-send-email-owasserm@redhat.com>
Date: Thu, 21 Mar 2013 17:55:29 +0100
Message-ID: <87hak4r8u6.fsf@elfo.elfo>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v3 2/9] Add socket_writev_buffer function
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Orit Wasserman <owasserm@redhat.com>
Cc: pbonzini@redhat.com, chegu_vinod@hp.com, qemu-devel@nongnu.org, mst@redhat.com

Orit Wasserman <owasserm@redhat.com> wrote:
D> Signed-off-by: Orit Wasserman <owasserm@redhat.com>
> ---
>  savevm.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/savevm.c b/savevm.c
> index 35c8d1e..baa45ae 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -39,6 +39,7 @@
>  #include "qmp-commands.h"
>  #include "trace.h"
>  #include "qemu/bitops.h"
> +#include "qemu/iov.h"
>  
>  #define SELF_ANNOUNCE_ROUNDS 5
>  
> @@ -171,6 +172,18 @@ static void coroutine_fn yield_until_fd_readable(int fd)
>      qemu_coroutine_yield();
>  }
>  
> +static int socket_writev_buffer(void *opaque, struct iovec *iov, int iovcnt)
> +{
> +    QEMUFileSocket *s = opaque;
> +    ssize_t len;
> +
> +    len = iov_send(s->fd, iov, iovcnt, 0, iov_size(iov, iovcnt));
> +    if (len < iov_size(iov, iovcnt)) {

Not the more expensive operation ever, but we can factor
  iov_size(iov, iovcnt)
value into one variable.

> +        len = -socket_error();
> +    }
> +    return len;
> +}
> +
>  static int socket_get_fd(void *opaque)
>  {
>      QEMUFileSocket *s = opaque;
> @@ -387,6 +400,7 @@ static const QEMUFileOps socket_read_ops = {
>  static const QEMUFileOps socket_write_ops = {
>      .get_fd =     socket_get_fd,
>      .put_buffer = socket_put_buffer,
> +    .writev_buffer = socket_writev_buffer,
>      .close =      socket_close
>  };