From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH] drm/i915: don't clear pfit at startup any more Date: Tue, 19 Mar 2013 11:53:19 +0200 Message-ID: <87hak7lnqo.fsf@gaia.fi.intel.com> References: <1362578114-6485-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id 98BD0E5C41 for ; Tue, 19 Mar 2013 02:53:35 -0700 (PDT) In-Reply-To: <1362578114-6485-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org Daniel Vetter writes: > Since > > commit 24a1f16de97c4cf0029d9acd04be06db32208726 > Author: Mika Kuoppala > Date: Fri Feb 8 16:35:37 2013 +0200 > > drm/i915: disable shared panel fitter for pipe > > We clear the single panel fitter when disabling the pipe it's attached to, so no > need to additionally clear it when there's no lvds port detected. Since that > alone isn't good enough e.g. when an external monitor is connected and the bios > uses the panel fitter on that output. > > Cc: Mika Kuoppala > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/intel_display.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 502cb28..8567506 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -8318,10 +8318,6 @@ static void intel_setup_outputs(struct drm_device *dev) > bool has_lvds; > > has_lvds = intel_lvds_init(dev); You can remove the has_lvds completely and change the return value of intel_lvds_init to void. -Mika > - if (!has_lvds && !HAS_PCH_SPLIT(dev)) { > - /* disable the panel fitter on everything but LVDS */ > - I915_WRITE(PFIT_CONTROL, 0); > - } > > if (!(HAS_DDI(dev) && (I915_READ(DDI_BUF_CTL(PORT_A)) & DDI_A_4_LANES))) > intel_crt_init(dev); > -- > 1.7.10.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx