From: Thomas Rast <trast@student.ethz.ch>
To: John Keeping <john@keeping.me.uk>
Cc: <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>,
Johan Herland <johan@herland.net>
Subject: Re: [PATCH] Revert "graph.c: mark private file-scope symbols as static"
Date: Sat, 2 Mar 2013 20:16:13 +0100 [thread overview]
Message-ID: <87haktwr2a.fsf@pctrast.inf.ethz.ch> (raw)
In-Reply-To: <50e7b3316fadbb550bea098ae92a0942a4429647.1362228122.git.john@keeping.me.uk> (John Keeping's message of "Sat, 2 Mar 2013 12:46:05 +0000")
John Keeping <john@keeping.me.uk> writes:
> This reverts commit ba35480439d05b8f6cca50527072194fe3278bbb.
>
> CGit uses these symbols to output the correct HTML around graph
> elements. Making these symbols private means that CGit cannot be
> updated to use Git 1.8.0 or newer, so let's not do that.
>
> Signed-off-by: John Keeping <john@keeping.me.uk>
> ---
>
> I realise that Git isn't a library so making the API useful for outside
> projects isn't a priority, but making these two methods public makes
> life a lot easier for CGit.
>
> Additionally, it seems that Johan added graph_set_column_colors
> specifically so that CGit should use it - there's no value to having
> that as a method just for its use in graph.c and he was the author of
> CGit commit 268b34a (ui-log: Colorize commit graph, 2010-11-15).
Perhaps you could add a comment in the source to prevent this from
happening again?
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2013-03-02 19:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-02 12:46 [PATCH] Revert "graph.c: mark private file-scope symbols as static" John Keeping
2013-03-02 14:54 ` Johan Herland
2013-03-02 19:16 ` Thomas Rast [this message]
2013-03-03 10:29 ` John Keeping
2013-03-03 21:08 ` Junio C Hamano
2013-03-03 21:42 ` John Keeping
2013-03-03 22:49 ` Junio C Hamano
2013-03-03 23:24 ` John Keeping
2013-03-03 23:32 ` Junio C Hamano
2013-03-04 0:03 ` [PATCH v2] " John Keeping
2013-03-04 0:12 ` Jason A. Donenfeld
2013-03-04 3:42 ` Junio C Hamano
2013-03-04 4:25 ` Jason A. Donenfeld
2013-03-04 0:52 ` Johan Herland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87haktwr2a.fsf@pctrast.inf.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
--cc=john@keeping.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.