From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH v2 3/3] modetest: Add a command line parameter to select
	the driver
Date: Tue, 12 Feb 2013 09:43:55 +0200
Message-ID: <87haliq8n8.fsf@intel.com>
References: <1360613625-4718-1-git-send-email-laurent.pinchart@ideasonboard.com>
	<1360613625-4718-4-git-send-email-laurent.pinchart@ideasonboard.com>
	<11436156.kyK6xg2gh8@avalon>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [143.182.124.37])
	by gabe.freedesktop.org (Postfix) with ESMTP id D6818E5C2A
	for <dri-devel@lists.freedesktop.org>;
	Mon, 11 Feb 2013 23:43:28 -0800 (PST)
In-Reply-To: <11436156.kyK6xg2gh8@avalon>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Mon, 11 Feb 2013, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> On Monday 11 February 2013 21:13:45 Laurent Pinchart wrote:
>> If the -M parameter is specific, modetest will use the requested device
>> name instead of trying its builtin list of device names.
>> 
>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> ---
>>  tests/modetest/modetest.c | 41 ++++++++++++++++++++++++++++-------------
>>  1 file changed, 28 insertions(+), 13 deletions(-)
>> 
>> diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c
>> index 34457e2..9a2d1f8 100644
>> --- a/tests/modetest/modetest.c
>> +++ b/tests/modetest/modetest.c
>
> [snip]
>
>> @@ -989,14 +996,27 @@ int main(int argc, char **argv)
>>  	if (argc == 1)
>>  		encoders = connectors = crtcs = planes = modes = framebuffers = 1;
>> 
>> -	for (i = 0; i < ARRAY_SIZE(modules); i++) {
>> -		printf("trying to load module %s...", modules[i]);
>> -		fd = drmOpen(modules[i], NULL);
>> +	if (module) {
>> +		fd = drmOpen(module, NULL);
>>  		if (fd < 0) {
>> -			printf("failed.\n");
>> -		} else {
>> -			printf("success.\n");
>> -			break;
>> +			fprintf(stderr, "failed to open device '%s'.\n", module);
>> +			return 1;
>> +		}
>> +	} else {
>> +		for (i = 0; i < ARRAY_SIZE(modules); i++) {
>> +			printf("trying to open device '%s'...", modules[i]);
>> +			fd = drmOpen(modules[i], NULL);
>> +			if (fd < 0) {
>> +				printf("failed.\n");
>> +			} else {
>> +				printf("success.\n");
>> +				break;
>> +			}
>> +		}
>> +
>> +		if (fd < 0) {
>> +			fprintf(stderr, "no device found.\n", module);
>
> I should sleep before sending patches... Sorry for the noise, v3 will fix 
> that.

If you fix that bit, you can slam my

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

on the series.