From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman) Subject: Re: [PATCH 06/21] userns: Print out socket uids in a user namespace aware fashion. Date: Tue, 14 Aug 2012 21:47:09 -0700 Message-ID: <87has4hicy.fsf@xmission.com> References: <87ehnav9n5.fsf@xmission.com> <1344889115-21610-1-git-send-email-ebiederm@xmission.com> <1344889115-21610-6-git-send-email-ebiederm@xmission.com> <201208132326.35045.remi@remlab.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <201208132326.35045.remi-AzDNUFsAnHasTnJN9+BGXg@public.gmane.org> (=?utf-8?Q?=22R=C3=A9mi?= Denis-Courmont"'s message of "Mon, 13 Aug 2012 23:26:34 +0300") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: =?utf-8?Q?R=C3=A9mi_Denis-Courmont?= Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: containers.vger.kernel.org IlLDqW1pIERlbmlzLUNvdXJtb250IiA8cmVtaUByZW1sYWIubmV0PiB3cml0ZXM6Cgo+IExlIGx1 bmRpIDEzIGFvw7t0IDIwMTIgMjM6MTg6MjAsIHZvdXMgYXZleiDDqWNyaXQgOgo+PiBGcm9tOiAi RXJpYyBXLiBCaWVkZXJtYW4iIDxlYmllZGVybUB4bWlzc2lvbi5jb20+Cj4+IAo+PiBDYzogRGF2 aWQgTWlsbGVyIDxkYXZlbUBkYXZlbWxvZnQubmV0Pgo+PiBDYzogQWxleGV5IEt1em5ldHNvdiA8 a3V6bmV0QG1zMi5pbnIuYWMucnU+Cj4+IENjOiBKYW1lcyBNb3JyaXMgPGptb3JyaXNAbmFtZWku b3JnPgo+PiBDYzogSGlkZWFraSBZT1NISUZVSkkgPHlvc2hmdWppQGxpbnV4LWlwdjYub3JnPgo+ PiBDYzogUGF0cmljayBNY0hhcmR5IDxrYWJlckB0cmFzaC5uZXQ+Cj4+IENjOiBBcm5hbGRvIENh cnZhbGhvIGRlIE1lbG8gPGFjbWVAZ2hvc3Rwcm90b2NvbHMubmV0Pgo+PiBDYzogVmxhZCBZYXNl dmljaCA8dnlhc2V2aWNoQGdtYWlsLmNvbT4KPj4gQ2M6IFNyaWRoYXIgU2FtdWRyYWxhIDxzcmlA dXMuaWJtLmNvbT4KPj4gQWNrZWQtYnk6IFNlcmdlIEhhbGx5biA8c2VyZ2UuaGFsbHluQGNhbm9u aWNhbC5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6IEVyaWMgVy4gQmllZGVybWFuIDxlYmllZGVybUB4 bWlzc2lvbi5jb20+Cj4KPiBGV0lXLCAuLi4KCldlbGwgSSB3aWxsIHRha2UgZXZlcnkgYml0IG9m IHJldmlldyBJIGNhbiBnZXQuICBJdCBjYW4gYmUgdGVycmlibHkKZW1iYXJyYXNzaW5nIHRvIGRp c2NvdmVyIHlvdSBtZXNzZWQgdXAgdWlkL2dpZCBoYW5kbGluZyBhbmQgbm8gb25lCm5vdGljZWQg dGhlIHNlY3VyaXR5IGhvbGUgZm9yIDMga2VybmVsIHJlbGVhc2VzLi4uCgo+IEFja2VkLUJ5OiBS w6ltaSBEZW5pcy1Db3VybW9udCA8cmVtaUByZW1sYWIubmV0PgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpDb250YWluZXJzIG1haWxpbmcgbGlzdApDb250 YWluZXJzQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3Vu ZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2NvbnRhaW5lcnM= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752203Ab2HOErT (ORCPT ); Wed, 15 Aug 2012 00:47:19 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:53928 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751078Ab2HOErR convert rfc822-to-8bit (ORCPT ); Wed, 15 Aug 2012 00:47:17 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: =?utf-8?Q?R=C3=A9mi_Denis-Courmont?= Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org References: <87ehnav9n5.fsf@xmission.com> <1344889115-21610-1-git-send-email-ebiederm@xmission.com> <1344889115-21610-6-git-send-email-ebiederm@xmission.com> <201208132326.35045.remi@remlab.net> Date: Tue, 14 Aug 2012 21:47:09 -0700 In-Reply-To: <201208132326.35045.remi@remlab.net> (=?utf-8?Q?=22R=C3=A9mi?= Denis-Courmont"'s message of "Mon, 13 Aug 2012 23:26:34 +0300") Message-ID: <87has4hicy.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-XM-SPF: eid=;;;mid=;;;hst=in01.mta.xmission.com;;;ip=98.207.153.68;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/dtV5jRsjvsYu3klxsGDXCH+381rQuZK0= X-SA-Exim-Connect-IP: 98.207.153.68 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.1 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: T_TM2_M_HEADER_IN_MSG * -3.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0001] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: =?ISO-8859-1?Q?;R=c3=a9mi Denis-Courmont ?= X-Spam-Relay-Country: Subject: Re: [PATCH 06/21] userns: Print out socket uids in a user namespace aware fashion. X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Fri, 06 Aug 2010 16:31:04 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Rémi Denis-Courmont" writes: > Le lundi 13 août 2012 23:18:20, vous avez écrit : >> From: "Eric W. Biederman" >> >> Cc: David Miller >> Cc: Alexey Kuznetsov >> Cc: James Morris >> Cc: Hideaki YOSHIFUJI >> Cc: Patrick McHardy >> Cc: Arnaldo Carvalho de Melo >> Cc: Vlad Yasevich >> Cc: Sridhar Samudrala >> Acked-by: Serge Hallyn >> Signed-off-by: Eric W. Biederman > > FWIW, ... Well I will take every bit of review I can get. It can be terribly embarrassing to discover you messed up uid/gid handling and no one noticed the security hole for 3 kernel releases... > Acked-By: Rémi Denis-Courmont