From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH] mmc: mxs-mmc: Add wp-inverted property Date: Thu, 19 Jul 2012 11:02:10 -0400 Message-ID: <87hat394lp.fsf@octavius.laptop.org> References: <1339181738-22769-1-git-send-email-marex@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from void.printf.net ([89.145.121.20]:59609 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751322Ab2GSPCU convert rfc822-to-8bit (ORCPT ); Thu, 19 Jul 2012 11:02:20 -0400 In-Reply-To: <1339181738-22769-1-git-send-email-marex@denx.de> (Marek Vasut's message of "Fri, 8 Jun 2012 20:55:38 +0200") Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Marek Vasut Cc: linux-mmc@vger.kernel.org, Shawn Guo , Fabio Estevam , Lothar =?utf-8?Q?Wa=C3=9Fmann?= Hi Marek, On Fri, Jun 08 2012, Marek Vasut wrote: > The write-protect GPIO is inverted on some boards. Handle such case. > > Signed-off-by: Marek Vasut > Cc: Shawn Guo > Cc: Fabio Estevam > Cc: linux-mmc@vger.kernel.org > Cc: Chris Ball > Cc: Lothar Wa=C3=9Fmann > --- > drivers/mmc/host/mxs-mmc.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c > index 34a9026..c6964e1 100644 > --- a/drivers/mmc/host/mxs-mmc.c > +++ b/drivers/mmc/host/mxs-mmc.c > @@ -164,16 +164,23 @@ struct mxs_mmc_host { > spinlock_t lock; > int sdio_irq_en; > int wp_gpio; > + int wp_inverted:1; Mind if I change this to "bool wp_inverted;"? Other than that, looks fine and I'll merge it for 3.6. Thanks, - Chris. --=20 Chris Ball One Laptop Per Child