From: Rusty Russell <rusty@ozlabs.org>
To: Jason Vas Dias <jason.vas.dias@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Andreas Herrmann <herrmann.der.user@googlemail.com>,
Matthew Garrett <mjg@redhat.com>, Len Brown <lenb@kernel.org>,
Comrade DOS <suloevdmitry@gmail.com>
Subject: Re: [PATCH: 1/1] ACPI: make evaluation of thermal trip points before temperature or vice versa dependant on new "temp_b4_trip" module parameter to support older AMD x86_64s
Date: Tue, 10 Jul 2012 09:36:48 +0930 [thread overview]
Message-ID: <87hatgqy1z.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CALyZvKxP793Qq5-SHt1ExfivHWhNeMOgVWD6qDsQ0kjEBOA96w@mail.gmail.com>
On Mon, 9 Jul 2012 19:16:24 +0100, Jason Vas Dias <jason.vas.dias@gmail.com> wrote:
> Thanks Rusty - sorry I didn't see your email until now - revised patch
> addressing your comments attached -
> BTW, sorry about the word wrap on the initial posting - should I
> attach a '.patch' file or inline ? Trying both .
The inline one was wrapped.
> +static int thermal_temp_b4_trip(const struct dmi_system_id *d) {
> +
> + printk(KERN_NOTICE "ACPI: %s detected: : "
> + "getting temperature before trip point
> initialisation\n", d->ident);
> + temp_b4_trip = TRUE;
> + return 0;
> +}
TRUE? true is standard with stdbool.h.
The patch itself looks reasonable, but it's not my area: I just spotted
the module_param() abuse :)
Cheers,
Rusty.
next prev parent reply other threads:[~2012-07-10 0:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 18:50 [PATCH: 1/1] ACPI: make evaluation of thermal trip points before temperature or vice versa dependant on new "temp_b4_trip" module parameter to support older AMD x86_64s Jason Vas Dias
2012-07-09 0:30 ` Rusty Russell
2012-07-09 18:16 ` Jason Vas Dias
2012-07-10 0:06 ` Rusty Russell [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-07-14 11:45 Jason Vas Dias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hatgqy1z.fsf@rustcorp.com.au \
--to=rusty@ozlabs.org \
--cc=herrmann.der.user@googlemail.com \
--cc=jason.vas.dias@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=suloevdmitry@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.