From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48169)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1S0CkP-0000l6-O8
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 09:00:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1S0CkF-0003ku-JT
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 09:00:45 -0500
Received: from mx1.redhat.com ([209.132.183.28]:12786)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1S0CkF-0003kF-Bb
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 09:00:35 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1329905754-11873-5-git-send-email-i.mitsyanko@samsung.com> (Igor
	Mitsyanko's message of "Wed, 22 Feb 2012 14:15:53 +0400")
References: <1329905754-11873-1-git-send-email-i.mitsyanko@samsung.com>
	<1329905754-11873-5-git-send-email-i.mitsyanko@samsung.com>
Date: Wed, 22 Feb 2012 15:00:26 +0100
Message-ID: <87hayjufwl.fsf@elfo.elfo>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 4/5] vmstate: refactor and move
	VMSTATE_UINTTL* macro
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mitsyanko <i.mitsyanko@samsung.com>
Cc: peter.maydell@linaro.org, balrog@zabor.org, e.voevodin@samsung.com, qemu-devel@nongnu.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, m.kozlov@samsung.com, afaerber@suse.de

Igor Mitsyanko <i.mitsyanko@samsung.com> wrote:
> Instead of defining VMSTATE_UINTTL* based on TARGET_LONG_BITS value, we can
> use qemu_put_betls/qemu_get_betls functions. These two functions depend on
> TARGET_LONG_BITS as well, and this new approach for VMSTATE_UINTTL* will result
> in the same thing as before (will call qemu_get_be32s/qemu_put_be32s for 32-bit
> target or qemu_put_be64s/qemu_get_be64s for 64-bit target).
> Move VMSTATE_UINTTL* definitions to vmstate.h where they belong.

The idea was to removed the other functions.  Notice that the cases are
equivalent.  i.e. this just bring us a new type that we have to
represent, maintain.  The other makes use to use a define, take your poison.

Later, Juan.