All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-omap@vger.kernel.org, p-titiano@ti.com
Subject: Re: [PATCH/RFC 2/4] OMAP2: PM debug: remove register dumping
Date: Tue, 31 May 2011 18:34:11 -0700	[thread overview]
Message-ID: <87hb8al4h8.fsf@ti.com> (raw)
In-Reply-To: <4DE3448E.6060502@ti.com> (Santosh Shilimkar's message of "Mon, 30 May 2011 12:47:34 +0530")

Santosh Shilimkar <santosh.shilimkar@ti.com> writes:

> On 5/27/2011 4:32 AM, Kevin Hilman wrote:
>> Signed-off-by: Kevin Hilman<khilman@ti.com>
>
> Do you plan to keep wroking the patch which dumps registers
> before and after WFI ?

No.

I haven't thought through all the details yet, but I'm hoping that
dropping this feature will "encourage" others to help think about it as
well. ;)

Ideally, I'd like to see this handled by perf/ftrace.  We now have
tracepoints for clock, clockdomain and powerdomain events.  Maybe adding
additional data for each of these tracepoints which snapshots some key
registers values would be useful.  Then, visualizing with tools like
pytimechart or kernelshark could be done.

Another option would be a new driver which adds a way to snapshot
registers into a hash-table based on address (maybe triggered by the
existing tracepoints.)  This data could then be readable from userspace
via the drivers read/write interface, and displayed with a tool that
already knows about all the registers/bitfields etc. (e.g. omapconf.)

I'd guess the the latter is probably prefered since all the register &
bitfield knowlege is already in a tool like omapconf.

> Ofcourse this patch is in your pm-debug branch.

Right, I'll be dropping that branch.

> For this change
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>	

Thanks,

Kevin

  reply	other threads:[~2011-06-01  1:34 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-26 23:02 [PATCH/RFC 0/4] OMAP: PM debug: remove register dump, misc cleanups Kevin Hilman
2011-05-26 23:02 ` [PATCH/RFC 1/4] OMAP3: PM debug: remove sleep_while_idle feature Kevin Hilman
2011-05-27  7:37   ` Jean Pihet
2011-05-27 15:26     ` Kevin Hilman
2011-05-27 16:01       ` Jean Pihet
2011-05-30  7:15   ` Santosh Shilimkar
2011-05-30  7:59     ` Jean Pihet
2011-05-26 23:02 ` [PATCH/RFC 2/4] OMAP2: PM debug: remove register dumping Kevin Hilman
2011-05-30  7:17   ` Santosh Shilimkar
2011-06-01  1:34     ` Kevin Hilman [this message]
2011-05-30  8:05   ` Jean Pihet
2011-05-31  8:24     ` Titiano, Patrick
2011-06-01  1:40       ` Kevin Hilman
2011-06-01 14:28         ` Titiano, Patrick
2011-05-26 23:02 ` [PATCH/RFC 3/4] OMAP3: " Kevin Hilman
2011-05-30  7:18   ` Santosh Shilimkar
2011-05-30  8:06     ` Jean Pihet
2011-05-26 23:02 ` [PATCH/RFC 4/4] OMAP2: PM debug: move wakeup timer into clockevent code Kevin Hilman
2011-05-27  5:18   ` Santosh Shilimkar
2011-05-30  7:21     ` Santosh Shilimkar
2011-05-30  8:08       ` Jean Pihet
2011-05-30  8:10         ` Santosh Shilimkar
2011-05-27  7:34 ` [PATCH/RFC 0/4] OMAP: PM debug: remove register dump, misc cleanups Jean Pihet
2011-05-27 15:00   ` Kevin Hilman
2011-06-13 12:28 ` Santosh Shilimkar
2011-06-16  0:33   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hb8al4h8.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=p-titiano@ti.com \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.