diff for duplicates of <87hb9bg35z.fsf@ti.com> diff --git a/a/1.txt b/N1/1.txt index 06e05fa..beec2a8 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,28 +6,28 @@ >> Remove the OMAP1 #ifdef and MPUIO special case for _clear_gpio_irqbank() >> >> The MPUIOs do not need a register access to ack/clear the IRQ status, ->> since reading the IRQ status clears it. In addition, the MPUIO +>> since reading the IRQ status clears it. ?In addition, the MPUIO >> irq_chip has an empty ack method, so _clear_gpio_irqbank() is never >> used for MPUIOs. >> >> Signed-off-by: Kevin Hilman <khilman@ti.com> >> --- ->> arch/arm/plat-omap/gpio.c | 6 ------ ->> 1 files changed, 0 insertions(+), 6 deletions(-) +>> ?arch/arm/plat-omap/gpio.c | ? ?6 ------ +>> ?1 files changed, 0 insertions(+), 6 deletions(-) >> >> diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c >> index fe6971a..8b5ca6e 100644 >> --- a/arch/arm/plat-omap/gpio.c >> +++ b/arch/arm/plat-omap/gpio.c >> @@ -770,12 +770,6 @@ static void _clear_gpio_irqbank(struct gpio_bank *bank, int gpio_mask) ->> void __iomem *reg = bank->base; +>> ? ? ? ?void __iomem *reg = bank->base; >> ->> switch (bank->method) { +>> ? ? ? ?switch (bank->method) { >> -#ifdef CONFIG_ARCH_OMAP1 ->> - case METHOD_MPUIO: ->> - /* MPUIO irqstatus is reset by reading the status register, ->> - * so do nothing here */ ->> - return; +>> - ? ? ? case METHOD_MPUIO: +>> - ? ? ? ? ? ? ? /* MPUIO irqstatus is reset by reading the status register, +>> - ? ? ? ? ? ? ? ?* so do nothing here */ +>> - ? ? ? ? ? ? ? return; >> -#endif > > The default case has a "WARN_ON(1)". I guess WARN_ON() @@ -37,9 +37,3 @@ As stated in the changelog, this function is never called for MPUIO banks, so the warning should not be hit. Kevin - - --- -To unsubscribe from this list: send the line "unsubscribe linux-omap" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 8683b43..78e2bca 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,13 +1,10 @@ "ref\01303513327-14532-1-git-send-email-khilman@ti.com\0" "ref\01303513327-14532-3-git-send-email-khilman@ti.com\0" "ref\0BANLkTinmf5EWwbWrYJHz=Z19v1EkG-MPvg@mail.gmail.com\0" - "From\0Kevin Hilman <khilman@ti.com>\0" - "Subject\0Re: [PATCH 02/15] OMAP: GPIO: remove MPUIO handling from _clear_gpio_irqbank()\0" + "From\0khilman@ti.com (Kevin Hilman)\0" + "Subject\0[PATCH 02/15] OMAP: GPIO: remove MPUIO handling from _clear_gpio_irqbank()\0" "Date\0Tue, 03 May 2011 09:27:36 -0700\0" - "To\0Varadarajan" - " Charulatha <charu@ti.com>\0" - "Cc\0linux-omap@vger.kernel.org" - " linux-arm-kernel@lists.infradead.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "\"Varadarajan, Charulatha\" <charu@ti.com> writes:\n" @@ -18,28 +15,28 @@ ">> Remove the OMAP1 #ifdef and MPUIO special case for _clear_gpio_irqbank()\n" ">>\n" ">> The MPUIOs do not need a register access to ack/clear the IRQ status,\n" - ">> since reading the IRQ status clears it. \302\240In addition, the MPUIO\n" + ">> since reading the IRQ status clears it. ?In addition, the MPUIO\n" ">> irq_chip has an empty ack method, so _clear_gpio_irqbank() is never\n" ">> used for MPUIOs.\n" ">>\n" ">> Signed-off-by: Kevin Hilman <khilman@ti.com>\n" ">> ---\n" - ">> \302\240arch/arm/plat-omap/gpio.c | \302\240 \302\2406 ------\n" - ">> \302\2401 files changed, 0 insertions(+), 6 deletions(-)\n" + ">> ?arch/arm/plat-omap/gpio.c | ? ?6 ------\n" + ">> ?1 files changed, 0 insertions(+), 6 deletions(-)\n" ">>\n" ">> diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c\n" ">> index fe6971a..8b5ca6e 100644\n" ">> --- a/arch/arm/plat-omap/gpio.c\n" ">> +++ b/arch/arm/plat-omap/gpio.c\n" ">> @@ -770,12 +770,6 @@ static void _clear_gpio_irqbank(struct gpio_bank *bank, int gpio_mask)\n" - ">> \302\240 \302\240 \302\240 \302\240void __iomem *reg = bank->base;\n" + ">> ? ? ? ?void __iomem *reg = bank->base;\n" ">>\n" - ">> \302\240 \302\240 \302\240 \302\240switch (bank->method) {\n" + ">> ? ? ? ?switch (bank->method) {\n" ">> -#ifdef CONFIG_ARCH_OMAP1\n" - ">> - \302\240 \302\240 \302\240 case METHOD_MPUIO:\n" - ">> - \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 /* MPUIO irqstatus is reset by reading the status register,\n" - ">> - \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240* so do nothing here */\n" - ">> - \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 return;\n" + ">> - ? ? ? case METHOD_MPUIO:\n" + ">> - ? ? ? ? ? ? ? /* MPUIO irqstatus is reset by reading the status register,\n" + ">> - ? ? ? ? ? ? ? ?* so do nothing here */\n" + ">> - ? ? ? ? ? ? ? return;\n" ">> -#endif\n" ">\n" "> The default case has a \"WARN_ON(1)\". I guess WARN_ON()\n" @@ -48,12 +45,6 @@ "As stated in the changelog, this function is never called for MPUIO\n" "banks, so the warning should not be hit.\n" "\n" - "Kevin\n" - "\n" - "\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-omap\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + Kevin -7ee366a01931fb9bcaa6cd78fe9586ebbdfef963158357d3ddbac18fadc6b4fd +728d467bdc9a76137f40e3be59c22918d94526a5a194be5fef7481efb0528f5c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.