From: Kevin Hilman <khilman@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, Benoit Cousson <b-cousson@ti.com>
Subject: Re: [PATCH 4/7] OMAP2+: powerdomain: add voltage domain lookup during register
Date: Tue, 22 Mar 2011 17:17:35 -0700 [thread overview]
Message-ID: <87hbaubsgw.fsf@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1103221313460.11798@utopia.booyaka.com> (Paul Walmsley's message of "Tue, 22 Mar 2011 13:23:39 -0600 (MDT)")
Paul Walmsley <paul@pwsan.com> writes:
> Hi Kevin,
>
> a couple of comments, now that i have the chance to look this over
> closely.
>
> Probably we should require every powerdomain to have a voltagedomain.
> This will avoid the problems we're having with the clocks, in which not
> every clock has a clockdomain pointer.
>
> So I'd suggest splitting this patch up into two patches -- one to make the
> changes the powerdomain structure, and the second to add the code into the
> powerdomain.c. Between these two patches, we'd need patches to the
> powerdomain data to add the voltagedomain names in.
OK, Benoit and I talked earlier today and agreed on this as well. He
has already generated the OMAP4 data as well, so split up, and drop the
checks below as you suggest.
Kevin
next prev parent reply other threads:[~2011-03-23 0:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-19 0:18 [PATCH 0/7] OMAP2+: voltage layer cleanup and restructure Kevin Hilman
2011-03-19 0:18 ` [PATCH 1/7] OMAP2+: hwmod: remove unused voltagedomain pointer Kevin Hilman
2011-03-21 13:08 ` Cousson, Benoit
2011-03-21 15:32 ` Kevin Hilman
2011-03-24 13:03 ` Gulati, Shweta
2011-03-24 14:00 ` Kevin Hilman
2011-03-24 15:14 ` Cousson, Benoit
2011-03-25 5:00 ` Gulati, Shweta
2011-03-22 19:13 ` Paul Walmsley
2011-03-19 0:18 ` [PATCH 2/7] OMAP2+: voltage: move PRCM mod offets into VDD structure Kevin Hilman
2011-03-19 4:41 ` Santosh Shilimkar
2011-03-21 15:21 ` Kevin Hilman
2011-03-21 10:53 ` Premi, Sanjeev
2011-03-21 15:26 ` Kevin Hilman
2011-03-23 14:16 ` Kevin Hilman
2011-03-19 0:18 ` [PATCH 3/7] OMAP2+: voltage: start towards a new voltagedomain layer Kevin Hilman
2011-03-19 0:18 ` [PATCH 4/7] OMAP2+: powerdomain: add voltage domain lookup during register Kevin Hilman
2011-03-22 19:23 ` Paul Walmsley
2011-03-22 20:59 ` Cousson, Benoit
2011-03-22 22:08 ` Paul Walmsley
2011-03-22 23:04 ` Cousson, Benoit
2011-04-02 1:17 ` Paul Walmsley
2011-03-23 0:17 ` Kevin Hilman [this message]
2011-03-19 0:18 ` [PATCH 5/7] OMAP2+: voltage: keep track of powerdomains in each voltagedomain Kevin Hilman
2011-03-22 19:35 ` Paul Walmsley
2011-03-23 0:18 ` Kevin Hilman
2011-03-19 0:18 ` [PATCH 6/7] OMAP2+: voltage: move prm_irqst_reg from VP into voltage domain Kevin Hilman
2011-03-19 0:18 ` [PATCH 7/7] OMAP3: powerdomain data: add voltage domains Kevin Hilman
2011-03-22 19:30 ` Paul Walmsley
2011-03-22 21:09 ` Cousson, Benoit
2011-03-22 22:15 ` Paul Walmsley
2011-03-23 0:20 ` Kevin Hilman
2011-03-23 0:31 ` [PATCH 0/7] OMAP2+: voltage layer cleanup and restructure Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hbaubsgw.fsf@ti.com \
--to=khilman@ti.com \
--cc=b-cousson@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.