Re: [RFC/PATCH 1/2] omap: mailbox: initial hwmod support

[Kevin Hilman <khilman@deeprootsystems.com>]

Felipe Contreras <felipe.contreras@gmail.com> writes:

> On Tue, May 25, 2010 at 5:49 PM, Kevin Hilman
> <khilman@deeprootsystems.com> wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> On Tue, May 25, 2010 at 3:00 AM, Kevin Hilman
>>> <khilman@deeprootsystems.com> wrote:
>>>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>>>

[...]

>>>>> -static struct platform_device mbox_device = {
>>>>> -     .name           = "omap-mailbox",
>>>>> -     .id             = -1,
>>>>> -};
>>>>> +     pdata.base_addr = hwmod->_rt_va;
>>>>
>>>> Shouldn't need the base address in pdata.  The driver should just do a
>>>> platform_get_resource() to get the physical address and then ioremap.
>>>
>>> But the hwmod code already did ioremap in _find_mpu_rt_base().
>>
>> Yes, but that's a hwmod-internal implementation detail that may
>> change, or may not be needed for some hwmods, or may be iounmapped
>> after hwmod init etc.
>
> So I have to do another ioremap()?

Yes.

But keep in mind that these L4 devices have static mappings, so there
really not an additional mapping created.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html