From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Monakhov Subject: Re: [PATCH 0/6] RFC quota: Redesign IO error handling interface Date: Wed, 05 May 2010 12:45:11 +0400 Message-ID: <87hbmmhh48.fsf@openvz.org> References: <1270749865-25441-1-git-send-email-dmonakhov@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: jack@suse.cz To: linux-fsdevel@vger.kernel.org Return-path: Received: from mail-bw0-f225.google.com ([209.85.218.225]:49429 "EHLO mail-bw0-f225.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933866Ab0EEIpP (ORCPT ); Wed, 5 May 2010 04:45:15 -0400 Received: by bwz25 with SMTP id 25so2766362bwz.28 for ; Wed, 05 May 2010 01:45:14 -0700 (PDT) In-Reply-To: <1270749865-25441-1-git-send-email-dmonakhov@openvz.org> (Dmitry Monakhov's message of "Thu, 8 Apr 2010 22:04:19 +0400") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Jan, can you please take a look at following patch set it starts here: http://marc.info/?l=linux-fsdevel&m=127074989804295&w=2 Do you agree with approach? Would you accept updated version for recent merge window? Dmitry Monakhov writes: > This patchset is tended to provide interface for handling IO errors > from internal quota code. > Any error must being returned to fs-caller to signal about possible > quota inconsistency. I've done it in following way: > > 1) Handle low-level io errors from dqget() and it's callers > 2) Handle errors from dquot_initialize > This path catch most of IO error, but no all. > 3) Check what i_dquot was initialized in each low-level function. > There are two types of such functions > 3A) Charging functions (alloc_{space,inode}): Caller of such > function may easy handle an error and abort an operation. > 3B) nofail functions (claim_space,free_{space,inode}) > In most cases caller can not abort an operation even if > inode's quotas was semi-initialized, so I just skip this > functions for now. > I would like to know you ideas suggestions about this. > Note: Only ext4's part was basically tested for now, others was just > compile tested.