From: Kevin Hilman <khilman@deeprootsystems.com>
To: Ranjith Lohithakshan <ranjithl@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] OMAP3: PM: Fix compilation error observed when cpufreq is disabled
Date: Thu, 29 Apr 2010 07:02:42 -0700 [thread overview]
Message-ID: <87hbmu73wd.fsf@deeprootsystems.com> (raw)
In-Reply-To: <4BD9093E.7010600@ti.com> (Ranjith Lohithakshan's message of "Thu\, 29 Apr 2010 09\:51\:18 +0530")
Ranjith Lohithakshan <ranjithl@ti.com> writes:
> On Thu, 29-Apr-10 3:00 AM +0530, Kevin Hilman wrote:
>> Ranjith Lohithakshan <ranjithl@ti.com> writes:
>>
>>> Currently on PM branch, compilation fails when cpufreq is disabled
>>>
>>> arch/arm/mach-omap2/clock3xxx_data.c: In function 'omap3xxx_clk_init':
>>> arch/arm/mach-omap2/clock3xxx_data.c:3563: error: 'struct clk_functions'
>>> has no member named 'clk_init_cpufreq_table'
>>> arch/arm/mach-omap2/clock3xxx_data.c:3564: error:
>>> 'omap3_clk_init_cpufreq_table' undeclared (first use
>>> in this function)
>>> arch/arm/mach-omap2/clock3xxx_data.c:3564: error: (Each undeclared
>>> identifier is reported only once
>>> arch/arm/mach-omap2/clock3xxx_data.c:3564: error: for each function it
>>> appears in.)
>>> make[1]: *** [arch/arm/mach-omap2/clock3xxx_data.o] Error 1
>>> make: *** [arch/arm/mach-omap2] Error 2
>>>
>>> This patch fixes the issue by avoiding runtime init of
>>> clk_init_cpufreq_table in omap3xxx_clk_init and instead doing it when
>>> omap2_clk_functions are defined.
>>>
>>> Signed-off-by: Ranjith Lohithakshan <ranjithl@ti.com>
>>
>> Do you still have this problem? I'm unable to reproduce on current PM branch.
>
> No, I don't see this now. Might have got fixed in some of the recent
> changes.
>
> Just FYI, I now see a linkage error with omap3_evm_defconfig
>
> arch/arm/mach-omap2/built-in.o: In function `sr_configure_vp':
> /tmp/ranjith/l-o-new/arch/arm/mach-omap2/smartreflex.c:315: undefined
> reference to `omap_twl_uv_to_vsel'
> /tmp/ranjith/l-o-new/arch/arm/mach-omap2/smartreflex.c:364: undefined
> reference to `omap_twl_uv_to_vsel'
> arch/arm/mach-omap2/built-in.o: In function `sr_enable':
> /tmp/ranjith/l-o-new/arch/arm/mach-omap2/smartreflex.c:609: undefined
> reference to `omap_twl_uv_to_vsel'
> arch/arm/mach-omap2/built-in.o: In function `sr_reset_voltage':
> /tmp/ranjith/l-o-new/arch/arm/mach-omap2/smartreflex.c:478: undefined
> reference to `omap_twl_uv_to_vsel'
> /tmp/ranjith/l-o-new/arch/arm/mach-omap2/smartreflex.c:496: undefined
> reference to `omap_twl_uv_to_vsel'
> make: *** [.tmp_vmlinux1] Error 1
>
Yes, I saw that too when trying to reproduce your problem.
SmartReflex currently has a dependency on SRF where these OPP functions
are defined, and this needs to be fixed.
Kevin
prev parent reply other threads:[~2010-04-30 22:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 10:46 [PATCH] OMAP3: PM: Fix compilation error observed when cpufreq is disabled Ranjith Lohithakshan
2010-04-28 21:30 ` Kevin Hilman
2010-04-29 4:21 ` Ranjith Lohithakshan
2010-04-29 14:02 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hbmu73wd.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=ranjithl@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.