All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sebastian Spaeth" <Sebastian@SSpaeth.de>
To: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>,
	openembedded-devel@lists.openembedded.org
Cc: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
Subject: Re: [PATCH v2] packaged-staging.bbclass: use 'os.unlink()' instead of spawning 'rm'
Date: Wed, 14 Apr 2010 14:48:52 +0200	[thread overview]
Message-ID: <87hbne8aiz.fsf@SSpaeth.de> (raw)
In-Reply-To: <1271238939-7065-1-git-send-email-enrico.scholz@sigma-chemnitz.de>

On 2010-04-14, Enrico Scholz wrote:

> @@ -227,7 +238,9 @@ python packagestage_scenefunc () {
> -        os.system('rm -f ' + stamp + '.*')
> +	for fname in glob.glob(stamp + '.*'):
> +	    _package_unlink(fname)
> +

> @@ -260,8 +273,8 @@ python packagedstage_stampfixing_eventhandler() {
> -                        os.system('rm -f ' + dir)
> -                    os.system('rm -f ' + stamp)
> +			_package_unlink(dir)
> +		    _package_unlink(stamp)

Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>

Given you have made sure that those changed indentations are actually
intended (I have not looked at the context of that patch):

Acked-by: Sebastian Spaeth <Sebastian@SSpaeth.de>



  reply	other threads:[~2010-04-14 12:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-16 12:23 [PATCH] packaged-staging.bbclass: use 'os.unlink()' instead of spawning 'rm' Enrico Scholz
2010-03-17  2:05 ` Tom Rini
2010-03-17 10:00   ` Enrico Scholz
2010-03-17 17:05 ` Tom Rini
2010-03-17 17:39   ` Michael 'Mickey' Lauer
2010-03-17 17:48     ` Tom Rini
2010-03-17 18:18       ` Tom Rini
2010-04-14  9:55 ` [PATCH v2] " Enrico Scholz
2010-04-14 12:48   ` Sebastian Spaeth [this message]
2010-04-14 13:21     ` Enrico Scholz
2010-04-14 14:52   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hbne8aiz.fsf@SSpaeth.de \
    --to=sebastian@sspaeth.de \
    --cc=enrico.scholz@sigma-chemnitz.de \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.