Re: [PATCH] [OMAP1] mux: Add MMC mux pins for omap7xx

[Kevin Hilman <khilman@deeprootsystems.com>]

Cory Maccarrone <darkstar6262@gmail.com> writes:

> On Tue, Oct 6, 2009 at 10:30 AM, Nishanth Menon <nm@ti.com> wrote:
>> Cory Maccarrone had written, on 10/06/2009 08:53 AM, the following:
>>>
>>> There are three mux pins needed for omap7xx that differ
>>> from the other omap configurations.  This change adds the
>>> declarations into mux.c and mux.h.
>>>
>>> Signed-off-by: Cory Maccarrone <darkstar6262@gmail.com>
>>> ---
>>>  arch/arm/mach-omap1/mux.c             |    5 +++++
>>>  arch/arm/plat-omap/include/mach/mux.h |    5 +++++
>>>  2 files changed, 10 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-omap1/mux.c b/arch/arm/mach-omap1/mux.c
>>> index d59899d..feb6d8c 100644
>>> --- a/arch/arm/mach-omap1/mux.c
>>> +++ b/arch/arm/mach-omap1/mux.c
>>> @@ -51,6 +51,11 @@ MUX_CFG_7XX("E3_7XX_KBC4",        13,   25,    0,
>>> 24,   1, 0)
>>>  MUX_CFG_7XX("AA17_7XX_USB_DM",     2,   21,    0,   20,   0, 0)
>>>  MUX_CFG_7XX("W16_7XX_USB_PU_EN",   2,   25,    0,   24,   0, 0)
>>>  MUX_CFG_7XX("W17_7XX_USB_VBUSI",   2,   29,    0,   28,   0, 0)
>>> +
>>> +/* MMC Pins */
>>> +MUX_CFG_7XX("MMC_7XX_CMD",         2,    9,    0,    8,   1, 0)
>>> +MUX_CFG_7XX("MMC_7XX_CLK",         2,   13,    0,   12,   1, 0)
>>> +MUX_CFG_7XX("MMC_7XX_DAT0",        2,   17,    0,   16,   1, 0)
>>>  };
>>>  #define OMAP7XX_PINS_SZ                ARRAY_SIZE(omap7xx_pins)
>>>  #else
>>> diff --git a/arch/arm/plat-omap/include/mach/mux.h
>>> b/arch/arm/plat-omap/include/mach/mux.h
>>> index f3c1d8a..56e357e 100644
>>> --- a/arch/arm/plat-omap/include/mach/mux.h
>>> +++ b/arch/arm/plat-omap/include/mach/mux.h
>>> @@ -219,6 +219,11 @@ enum omap7xx_index {
>>>        AA17_7XX_USB_DM,
>>>        W16_7XX_USB_PU_EN,
>>>        W17_7XX_USB_VBUSI,
>>> +
>>> +       /* MMC */
>>> +       MMC_7XX_CMD,
>>> +       MMC_7XX_CLK,
>>> +       MMC_7XX_DAT0,
>>
>> probably a dumb question -> but should'nt these go off to bootloader
>> perhaps?
>>
>> --
>> Regards,
>> Nishanth Menon
>>
>
> Perhaps, although we use either EOL (for HTC Wizard) or Haret to boot,
> and they don't set up the right mux configuration for our board.
>
> This way though, we don't have to worry about the boot loader -- we
> can set it up right regardless of who boots us.

I agree with Cory.

I prefer that mux settings go into the kernel, even if they are setup
in the bootloader already.  It's better to have redundancy than wonder
what to do if changing boot loaders.

Kevin

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html