All of lore.kernel.org
 help / color / mirror / Atom feed
From: Teemu Likonen <tlikonen@iki.fi>
To: Allan Caffee <allan.caffee@gmail.com>
Cc: git@vger.kernel.org,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Jeff King <peff@peff.net>, Nanako Shiraishi <nanako3@lavabit.com>
Subject: Re: [PATCH] graph API: Added logic for colored edges
Date: Thu, 09 Apr 2009 20:58:51 +0300	[thread overview]
Message-ID: <87hc0x7lpg.fsf@iki.fi> (raw)
In-Reply-To: <20090407185724.GA9996@linux.vnet> (Allan Caffee's message of "Tue\, 7 Apr 2009 14\:57\:24 -0400")

On 2009-04-07 14:57 (-0400), Allan Caffee wrote:

> Modified the graph drawing logic to colorize edges based on
> parent-child relationships similiarly to gitk.

I like the colored graph very much, thanks. Unfortunately there are some
problems with aligning of log messages and headers. For example, try
this in git.git repository:


$ git log -1 --graph 796b137

*   commit 796b13781aecce551b8f92049a66646e60f31dce
|\ Merge: 6da14ee db12d97
| | Author: Junio C Hamano <gitster@pobox.com>
| | Date:   2009-04-08 23:41:27 -0700


Without colors or without your patch the alignment is correct:

$ git log -1 --graph --no-color 796b137

*   commit 796b13781aecce551b8f92049a66646e60f31dce
|\  Merge: 6da14ee db12d97
| | Author: Junio C Hamano <gitster@pobox.com>
| | Date:   2009-04-08 23:41:27 -0700


(Perhaps the "Merge:" header could have two spaces befor the data, but
this is  unrelated to --graph.)

  parent reply	other threads:[~2009-04-09 18:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090331235922.GA7411@linux.vnet>
2009-04-07 18:57 ` [PATCH] graph API: Added logic for colored edges Allan Caffee
2009-04-08  7:59   ` Junio C Hamano
2009-04-08 21:41     ` Allan Caffee
2009-04-09  0:29       ` Junio C Hamano
2009-04-09 22:22         ` [PATCH v3] " Allan Caffee
2009-04-12  8:44           ` Junio C Hamano
2009-04-12 17:43             ` Allan Caffee
2009-04-12 18:45               ` Junio C Hamano
2009-04-12 20:27                 ` [PATCH v4] " Allan Caffee
2009-04-12 21:59                   ` Junio C Hamano
2009-04-13 19:53                     ` [PATCH v5] " Allan Caffee
2009-04-09 17:58   ` Teemu Likonen [this message]
2009-04-09 22:08     ` [PATCH] " Allan Caffee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hc0x7lpg.fsf@iki.fi \
    --to=tlikonen@iki.fi \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=allan.caffee@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=nanako3@lavabit.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.