From: Kevin Hilman <khilman@deeprootsystems.com>
To: Sanjeev Premi <premi@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] PM: Fix compile warnings with !CONFIG_OMAP_PM_SRF
Date: Thu, 12 Mar 2009 15:00:14 -0700 [thread overview]
Message-ID: <87hc1y4d1t.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1236891507-5687-1-git-send-email-premi@ti.com> (Sanjeev Premi's message of "Fri\, 13 Mar 2009 02\:28\:27 +0530")
Sanjeev Premi <premi@ti.com> writes:
> Fixes the compile warnings:
>
> CC arch/arm/mach-omap2/pm.o
> arch/arm/mach-omap2/pm.c:47: warning: 'vdd1_locked' defined but not used
> arch/arm/mach-omap2/pm.c:48: warning: 'vdd2_locked' defined but not used
>
> Signed-off-by: Sanjeev Premi <premi@ti.com>
Thanks, pushing to PM, with a slight change. I moved the definitions
down into another #ifdef CONFIG_OMAP_PM_SRF instead of adding a new
one.
Kevin
> ---
> arch/arm/mach-omap2/pm.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c
> index 61c6dfb..0fe6f1a 100644
> --- a/arch/arm/mach-omap2/pm.c
> +++ b/arch/arm/mach-omap2/pm.c
> @@ -44,8 +44,10 @@ unsigned short clocks_off_while_idle;
> unsigned short enable_off_mode;
> unsigned short voltage_off_while_idle;
> atomic_t sleep_block = ATOMIC_INIT(0);
> +#ifdef CONFIG_OMAP_PM_SRF
> static int vdd1_locked;
> static int vdd2_locked;
> +#endif
>
> static ssize_t idle_show(struct kobject *, struct kobj_attribute *, char *);
> static ssize_t idle_store(struct kobject *k, struct kobj_attribute *,
> --
> 1.5.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-03-12 22:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 20:58 [PATCH] PM: Fix compile warnings with !CONFIG_OMAP_PM_SRF Sanjeev Premi
2009-03-12 22:00 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hc1y4d1t.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=premi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.