From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KTCmQ-0003g8-6H for mharc-grub-devel@gnu.org; Wed, 13 Aug 2008 05:36:34 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KTCmO-0003fA-BJ for grub-devel@gnu.org; Wed, 13 Aug 2008 05:36:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KTCmN-0003eT-Kk for grub-devel@gnu.org; Wed, 13 Aug 2008 05:36:31 -0400 Received: from [199.232.76.173] (port=41327 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KTCmN-0003eM-Di for grub-devel@gnu.org; Wed, 13 Aug 2008 05:36:31 -0400 Received: from smtp-vbr3.xs4all.nl ([194.109.24.23]:3765) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KTCmM-0006bd-Ue for grub-devel@gnu.org; Wed, 13 Aug 2008 05:36:31 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr3.xs4all.nl (8.13.8/8.13.8) with ESMTP id m7D9aSRZ011553 for ; Wed, 13 Aug 2008 11:36:29 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <1218558487.19045.8.camel@fz.local> <1218558734.19045.10.camel@fz.local> <87fxp9di59.fsf@xs4all.nl> <20080812224041.GB3141@thorin> Mail-Copies-To: mgerards@xs4all.nl Date: Wed, 13 Aug 2008 11:40:04 +0200 In-Reply-To: <20080812224041.GB3141@thorin> (Robert Millan's message of "Wed, 13 Aug 2008 00:40:41 +0200") Message-ID: <87hc9pb6dn.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] kern/err.c + disk/raid.c error handling fixes X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Aug 2008 09:36:32 -0000 Robert Millan writes: > On Tue, Aug 12, 2008 at 11:42:58PM +0200, Marco Gerards wrote: >> > [GRUB_UTIL] (grub_print_error): Use fprintf (stderr, ...) instead of >> > grub_printf. >> >> Why? >> >> It would be better to make a util/misc.c:grub_print_error instead of this > > Problem is that kern/err.c is already included in grub-probe. So then we would > have to add util/misc.c:grub_print_error _and_ disable grub_print_error. That might be better than adding fprintf to kern/ IMO. >> Please use -up for diff, you can use: >> $ svn diff --diff-cmd diff -x -up > > Thanks for the tip, I've been looking for this ;-) Now if only everyone would use this... :-) -- Marco