All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: Mike Frysinger <vapier.adi@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] blackfin / h8300 build error fix
Date: Wed, 30 Jul 2008 15:22:38 -0400	[thread overview]
Message-ID: <87hca7npmp.wl%ysato@users.sourceforge.jp> (raw)
In-Reply-To: <8bd0f97a0807300911n4ae81b70v97276abf612f6b3e@mail.gmail.com>

At Wed, 30 Jul 2008 12:11:37 -0400,
Mike Frysinger wrote:
> 
> On Wed, Jul 30, 2008 at 11:58 AM, Yoshinori Sato wrote:
> > init/main.c:781: undefined reference to `___early_initcall_end'
> >
> > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> >
> > ---
> >  include/asm-generic/vmlinux.lds.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> > index 6d88a92..07b2784 100644
> > --- a/include/asm-generic/vmlinux.lds.h
> > +++ b/include/asm-generic/vmlinux.lds.h
> > @@ -362,7 +362,7 @@
> >
> >  #define INITCALLS                                                      \
> >        *(.initcallearly.init)                                          \
> > -       __early_initcall_end = .;                                       \
> > +       VMLINUX_SYMBOL(__early_initcall_end) = .;                       \
> >        *(.initcall0.init)                                              \
> >        *(.initcall0s.init)                                             \
> >        *(.initcall1.init)                                              \
> > --
> > 1.5.6.3
> 
> nice catch, thanks ... looks like BUG_TABLE, TRACEDATA, and PERCPU are
> also broken, but blackfin/etc... arent using those which is why we
> havent noticed yet ...
> -mike

Thanks.
I fixed same.

Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>

 include/asm-generic/vmlinux.lds.h |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index 6d88a92..04cae96 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -333,9 +333,9 @@
 #define BUG_TABLE							\
 	. = ALIGN(8);							\
 	__bug_table : AT(ADDR(__bug_table) - LOAD_OFFSET) {		\
-		__start___bug_table = .;				\
+		VMLINUX_SYMBOL(__start___bug_table) = .;		\
 		*(__bug_table)						\
-		__stop___bug_table = .;					\
+		VMLINUX_SYMBOL(__stop___bug_table) = .;			\
 	}
 #else
 #define BUG_TABLE
@@ -345,9 +345,9 @@
 #define TRACEDATA							\
 	. = ALIGN(4);							\
 	.tracedata : AT(ADDR(.tracedata) - LOAD_OFFSET) {		\
-	  	__tracedata_start = .;					\
+	  	VMLINUX_SYMBOL(__tracedata_start) = .;			\
 		*(.tracedata)						\
-	  	__tracedata_end = .;					\
+	  	VMLINUX_SYMBOL(__tracedata_end) = .;			\
 	}
 #else
 #define TRACEDATA
@@ -362,7 +362,7 @@
 
 #define INITCALLS							\
 	*(.initcallearly.init)						\
-	__early_initcall_end = .;					\
+	VMLINUX_SYMBOL(__early_initcall_end) = .;			\
   	*(.initcall0.init)						\
   	*(.initcall0s.init)						\
   	*(.initcall1.init)						\
@@ -383,9 +383,9 @@
 
 #define PERCPU(align)							\
 	. = ALIGN(align);						\
-	__per_cpu_start = .;						\
+	VMLINUX_SYMBOL(__per_cpu_start) = .;				\
 	.data.percpu  : AT(ADDR(.data.percpu) - LOAD_OFFSET) {		\
 		*(.data.percpu)						\
 		*(.data.percpu.shared_aligned)				\
 	}								\
-	__per_cpu_end = .;
+	VMLINUX_SYMBOL(__per_cpu_end) = .;
-- 
1.5.6.3

-- 
Yoshinori Sato
<ysato@users.sourceforge.jp>

  reply	other threads:[~2008-07-30 19:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-30 15:58 [PATCH] blackfin / h8300 build error fix Yoshinori Sato
2008-07-30 16:11 ` Mike Frysinger
2008-07-30 19:22   ` Yoshinori Sato [this message]
2008-07-30 20:01     ` Andrew Morton
2008-07-31  0:26       ` [PATCH] Missing symbol prefix on vmlinux.lds.h Yoshinori Sato
2008-07-31  2:06         ` Andrew Morton
2008-07-31  3:20           ` Yoshinori Sato
2008-07-31  3:26       ` [PATCH] blackfin / h8300 build error fix Mike Frysinger
2008-07-31  3:37         ` Andrew Morton
2008-07-31  3:51           ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hca7npmp.wl%ysato@users.sourceforge.jp \
    --to=ysato@users.sourceforge.jp \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vapier.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.