From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KETSB-0008Dr-Vn for mharc-grub-devel@gnu.org; Thu, 03 Jul 2008 14:22:48 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KETSA-0008DF-9k for grub-devel@gnu.org; Thu, 03 Jul 2008 14:22:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KETS8-0008Ch-R5 for grub-devel@gnu.org; Thu, 03 Jul 2008 14:22:45 -0400 Received: from [199.232.76.173] (port=42572 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KETS8-0008Cd-J9 for grub-devel@gnu.org; Thu, 03 Jul 2008 14:22:44 -0400 Received: from smtp-vbr4.xs4all.nl ([194.109.24.24]:4210) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KETS8-0003xG-Bx for grub-devel@gnu.org; Thu, 03 Jul 2008 14:22:44 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr4.xs4all.nl (8.13.8/8.13.8) with ESMTP id m63IMhYK078499 for ; Thu, 3 Jul 2008 20:22:43 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20080701132532.GA19736@thorin> <20080701153337.GA6154@thorin> Mail-Copies-To: mgerards@xs4all.nl Date: Thu, 03 Jul 2008 20:31:05 +0200 In-Reply-To: <20080701153337.GA6154@thorin> (Robert Millan's message of "Tue, 1 Jul 2008 17:33:37 +0200") Message-ID: <87hcb66cra.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] pc & gpt partmap iterators don't abort when their hook requests it X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jul 2008 18:22:46 -0000 Robert Millan writes: > On Tue, Jul 01, 2008 at 03:25:32PM +0200, Robert Millan wrote: >> >> See ChangeLog for description. I'd really like to receive some review on >> this one, since the code it touches is so fragile (although I tested it on a >> typical setup and it works). > > Tough luck. Inmediately after this I noticed it breaks grub-setup (I tested it > by loading core.img directly). > > I found a few other callers that relied on the buggy behaviour. Here's a new > patch. Thanks for fixing this. I had a quick look and it looks sane at first sight. Did you have a look at the other modules as well? -- Marco