From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JH0eO-0005YT-HE for mharc-grub-devel@gnu.org; Mon, 21 Jan 2008 12:41:36 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JH0eM-0005WS-Dh for grub-devel@gnu.org; Mon, 21 Jan 2008 12:41:34 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JH0eK-0005UX-KB for grub-devel@gnu.org; Mon, 21 Jan 2008 12:41:33 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JH0eK-0005UO-GF for grub-devel@gnu.org; Mon, 21 Jan 2008 12:41:32 -0500 Received: from smtp-vbr14.xs4all.nl ([194.109.24.34]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JH0eK-0004Kf-F4 for grub-devel@gnu.org; Mon, 21 Jan 2008 12:41:32 -0500 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr14.xs4all.nl (8.13.8/8.13.8) with ESMTP id m0LHfURc091836 for ; Mon, 21 Jan 2008 18:41:31 +0100 (CET) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20080115171747.GA14625@thorin> <1200418959.17542.6.camel@dv> <20080115180055.GA21551@thorin> <87prvv863n.fsf@xs4all.nl> <20080121171151.GA3343@thorin> Mail-Copies-To: mgerards@xs4all.nl Date: Mon, 21 Jan 2008 18:42:42 +0100 In-Reply-To: <20080121171151.GA3343@thorin> (Robert Millan's message of "Mon, 21 Jan 2008 18:11:51 +0100") Message-ID: <87hch7848d.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] improve grub_mm_init_region() debug message X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2008 17:41:34 -0000 Robert Millan writes: > On Mon, Jan 21, 2008 at 06:02:20PM +0100, Marco Gerards wrote: >> Robert Millan writes: >> >> > On Tue, Jan 15, 2008 at 12:42:39PM -0500, Pavel Roskin wrote: >> >> >> >> On Tue, 2008-01-15 at 18:17 +0100, Robert Millan wrote: >> >> > - grub_dprintf ("mem", "Using memory for heap: addr=%p, size=%u\n", >> >> > addr, (unsigned int) size); >> >> > + grub_dprintf ("mem", "Using memory for heap: start=%p, end=%p\n", >> >> > addr, addr + size); >> >> >> >> Maybe addr+size-1 would be better? Inclusive boundaries are more >> >> intuitive. Just run "cat /proc/iomem" to see what I mean. >> > >> > Sounds better to me. >> > >> > Does this change (with addr + size -1) sound fine to everyone else? >> >> Why not showing both the range and the size. Isn't the size useful >> sometimes? > > When? What you typicaly want to debug is whether your mem region overlaps > with something else, or so. Well, it is fine for me. If I need the size, I will bring this up again. Feel free to commit the patch as suggested. -- Marco