From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1IqUPB-0000fj-4l for mharc-grub-devel@gnu.org; Fri, 09 Nov 2007 09:00:17 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IqUP9-0000ea-8o for grub-devel@gnu.org; Fri, 09 Nov 2007 09:00:15 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IqUP6-0000cS-Kk for grub-devel@gnu.org; Fri, 09 Nov 2007 09:00:14 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IqUP5-0000c6-Th for grub-devel@gnu.org; Fri, 09 Nov 2007 09:00:12 -0500 Received: from smtp-vbr6.xs4all.nl ([194.109.24.26]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IqUP5-0000sg-4O for grub-devel@gnu.org; Fri, 09 Nov 2007 09:00:11 -0500 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr6.xs4all.nl (8.13.8/8.13.8) with ESMTP id lA9E096b094194 for ; Fri, 9 Nov 2007 15:00:09 +0100 (CET) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <471D0F5B.20805@t-online.de> Mail-Copies-To: mgerards@xs4all.nl Date: Fri, 09 Nov 2007 15:00:40 +0100 In-Reply-To: <471D0F5B.20805@t-online.de> (Christian Franke's message of "Mon, 22 Oct 2007 23:00:11 +0200") Message-ID: <87hcjvmsc7.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] Fix packing issue of machine_mmap_entry X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2007 14:00:16 -0000 Christian Franke writes: > First patch related to the Cygwin port: > > struct machine_mmap_entry is sensitive to packing of 64 bit values > which apparently differs between gcc releases. Thanks! > Christian > > 2007-10-22 Christian Franke > > * include/grub/i386/pc/init.h (struct grub_machine_mmap_entry): > Add attribute packed, gcc 3.4.4 on Cygwin aligns this > to 64 bit boundary by default. > Add compile time assert to check packing. Can you remove the compile time assert? We usually check stuff like this using configure. If you can send in a patch for configure.ac, that would be appreciated. > > > --- grub2.orig/include/grub/i386/pc/init.h 2007-07-22 01:32:23.000000000 +0200 > +++ grub2/include/grub/i386/pc/init.h 2007-10-13 21:25:24.000000000 +0200 > @@ -40,10 +40,14 @@ grub_uint32_t grub_get_eisa_mmap (void); > struct grub_machine_mmap_entry > { > grub_uint32_t size; > - grub_uint64_t addr; > + grub_uint64_t addr; /* must be at offset 4, see startup.S */ I do not think this comment is required. It's fixed now :-) > grub_uint64_t len; > grub_uint32_t type; > -}; > +} __attribute__((packed)); -- Marco