From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1ICbIk-0001Oy-80 for mharc-grub-devel@gnu.org; Sun, 22 Jul 2007 09:16:46 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ICbIi-0001Oc-F6 for grub-devel@gnu.org; Sun, 22 Jul 2007 09:16:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ICbIg-0001NI-CH for grub-devel@gnu.org; Sun, 22 Jul 2007 09:16:43 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ICbIg-0001ND-0q for grub-devel@gnu.org; Sun, 22 Jul 2007 09:16:42 -0400 Received: from smtp-vbr13.xs4all.nl ([194.109.24.33]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ICbIf-0004J0-KU for grub-devel@gnu.org; Sun, 22 Jul 2007 09:16:41 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr13.xs4all.nl (8.13.8/8.13.8) with ESMTP id l6MDGeXj030867 for ; Sun, 22 Jul 2007 15:16:40 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20070627201153.GA7329@aragorn> Mail-Copies-To: mgerards@xs4all.nl Date: Sun, 22 Jul 2007 15:18:14 +0200 In-Reply-To: <20070627201153.GA7329@aragorn> (Robert Millan's message of "Wed, 27 Jun 2007 22:11:53 +0200") Message-ID: <87hcnwfug9.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: FreeBSD 4.6-4.9 Subject: Re: patch to get rid of hardcoded grub_*_init in grub-probe / grub-setup X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Jul 2007 13:16:44 -0000 Robert Millan writes: > As suggested by Marco, I adapted the framework to generate grub_init_all > / grub_fini_all functions from grub-emu to also be used on grub-probe and > grub-setup. > > Any comments on the patch? Two comments on the changelog entry. If you can fix those, you can apply the patch. -- Marco > 2007-06-27 Robert Millan > > * geninitheader.sh: Process file specified in first parameter rather > than hardcoding grub_modules_init.lst. > * geninit.sh: Likewise. Also, construct header name dynamicaly rather > than hardcoding grub_modules_init.h. > > * conf/common.rmk: Rename grub_modules_init.[ch] files associated with > grub-emu to grub_emu_init.[ch]. Add rules to build analogous > grub_probe_init.[ch] and grub_setup_init.[ch]. > > * conf/powerpc-ieee1275.rmk (grub_emu_DEPENDENCIES): Replace > grub_modules_init.h with grub_emu_init.h. > (grub_probe_*): Add new grub_probe_init.[ch] files. Please do list the functions, instead of using *. > * conf/i386-efi.rmk: Likewise. > * conf/i386-pc.rmk: Likewise. > (grub_setup_*): Add new grub_setup_init.[ch] files. Same here. > * util/grub-emu.c: Replace grub_modules_init.h with grub_emu_init.h. > * util/grub-probe.c: Include grub_probe_init.h. Use grub_init_all() > to initialize modules rather than a list of hardcoded functions. > * util/i386/pc/grub-setup.c: Include grub_setup_init.h. Use > grub_init_all() to initialize modules rather than a list of hardcoded > functions. -- Marco