Re: GRUB 1.95 cannot read the ufs filesystem

[Johan Rydberg <jrydberg@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 834 bytes --]

"Hitoshi Ozeki" <h-ozeki@ck2.so-net.ne.jp> writes:

> At first, When we use the 'strcmp' for the purpose of comparision C-strings,
> It requires to terminate with the NIL sentry('\0').
>
> ----begin-------------------------------
> grub_ufs_find_file (struct grub_ufs_data *data, const char *path)
> {
>   char fpath[grub_strlen (path)];  <-- not enough.
>   char *name = fpath;
>   char *next;
>   unsigned int pos = 0;
>   int dirino;
>   
>   grub_strncpy (fpath, path, grub_strlen (path));   <--without NIL.
> ----end---------------------------------

It feels easier to just add +1 at both the location.  Can anyone else
comment on this, please?

> The '.label' should set to 0.
> On the original code, The 'label' function returns the invalid pointer,
> so the 'ls -l' command gets wrong.

Marco?

~j

[-- Attachment #2: Type: application/pgp-signature, Size: 190 bytes --]